Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tl_track info not included in 'track_playback_ended' event #1402

Closed
jcass77 opened this issue Jan 20, 2016 · 1 comment
Closed

tl_track info not included in 'track_playback_ended' event #1402

jcass77 opened this issue Jan 20, 2016 · 1 comment
Assignees
@jcass77
Labels
A-core Area: Core layer C-bug Category: This is a bug
Milestone
v2.0 - Gapless an...

Comments

@jcass77
Copy link
Member

jcass77 commented Jan 20, 2016

When consume mode is enabled, the track_playback_ended event that is emitted does not include the tl_track information as expected.

This is due to the fact that the track is marked as having been played, and removed from the tracklist, by the time that the event is triggered.
@jcass77 jcass77 self-assigned this Jan 20, 2016
@jcass77 jcass77 mentioned this issue Jan 20, 2016
Merged
@jodal jodal added this to the v1.2 - Gapless and GStreamer 1.x milestone Jan 20, 2016
@jodal jodal added C-bug Category: This is a bug A-core Area: Core layer labels Jan 20, 2016
@jodal
Copy link
Member

jodal commented Jan 20, 2016

Fixed by PR #1403.

Next time, include "Fixes #1402" in one of the commit messages, and the bug will automatically be closed when the PR is merged.

Also, could you update the changelog? I forgot to think about that before merging.

@jodal jodal closed this as completed Jan 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jcass77 jcass77

Labels
A-core Area: Core layer C-bug Category: This is a bug
Projects
None yet
Milestone
v2.0 - Gapless and GStreamer 1.x
Development

No branches or pull requests
2 participants
@jodal @jcass77