New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate seek events to appsrc #1404

Closed
adamcik opened this Issue Jan 20, 2016 · 3 comments

Comments

2 participants
@adamcik
Member

adamcik commented Jan 20, 2016

Currently we get one seek data event per output in the tee. This can be easily verified by commenting out the dummy fakesink in the tee, or adding extra ones. The end result of this is that mopidy-spotify seeking isn't smooth, as we start playing from the seeked position and then do it again shortly afterwards.

Proper fix for this, assuming multiple outputs is still a goal is to have mopidy de-dupe this, or to do it ourselves via the new segment events getting to the tee.

@jodal jodal added this to the v1.2 - Gapless and GStreamer 1.x milestone Jan 20, 2016

@adamcik

This comment has been minimized.

Member

adamcik commented Jan 20, 2016

http://cgit.freedesktop.org/gstreamer/gstreamer/tree/docs/design/part-seeking.txt hints at the solution. I've just tested changing our code to send the seek event to the queue we have in front of the output bin. Sending it to the playbin, audio-sink bin or the outputs bin won't work as the default seek handling of a bin is to forward to all sinks. So using the queue as the spot to inject the event is the way to go.

@adamcik

This comment has been minimized.

Member

adamcik commented Jan 20, 2016

Though this idea might not work as it only seems to play a few seconds of the next song and then goes quiet for and extend time before coming back again. :/

@adamcik

This comment has been minimized.

Member

adamcik commented Jan 20, 2016

Correct fix might be an event probe on the src pad of the appsrc and rejecting all but the first or last seek event. We'll see tomorrow.

@adamcik adamcik self-assigned this Jan 20, 2016

@jodal jodal closed this in 0336b60 Feb 3, 2016

jodal added a commit that referenced this issue Feb 3, 2016

Merge pull request #1426 from adamcik/fix/1404-duplicate-seeks
audio: Prevent double seeks in appsrc (fixes: #1404)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment