New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error mapping GST state #1430

Closed
trygveaa opened this Issue Feb 5, 2016 · 3 comments

Comments

3 participants
@trygveaa
Member

trygveaa commented Feb 5, 2016

I played around with stuff adding and playing tracks etc. Not sure what triggered this.

Traceback (most recent call last):
  File "/home/trygve/dev/mopidy/mopidy/mopidy/audio/actor.py", line 210, in on_message
    self.on_playbin_state_changed(old_state, new_state, pending_state)
  File "/home/trygve/dev/mopidy/mopidy/mopidy/audio/actor.py", line 260, in on_playbin_state_changed
    target_state = _GST_STATE_MAPPING[self._audio._target_state]
KeyError: <enum GST_STATE_READY of type GstState>

@trygveaa trygveaa added the C-bug label Feb 5, 2016

@jodal

This comment has been minimized.

Member

jodal commented Feb 10, 2016

Am I right that this is a duplicate of #1222?

Does this lead to Mopidy being unusable, or does everything still seem to work?

@trygveaa

This comment has been minimized.

Member

trygveaa commented Feb 10, 2016

Yes, this is a duplicate. I hadn't seen/didn't remember #1222 when opening this. @adamcik said this on IRC after I opened this:

11:46:50 <+adamcik> trygveaa: #1430 is kinda a dupe if race free audio. At least the same error is what triggered that bug
11:51:38 <+adamcik> But we might just want to solve 1430 with a workaround and use the other issue to track a systematic fix of audio with respect to this

I think everything still worked after this happened.

@adamcik

This comment has been minimized.

Member

adamcik commented Feb 10, 2016

Quick fix is just to consider READY == PAUSED, it's not correct, and might show some weird results, but it won't break anything. So it's better than having these random errors.

jodal added a commit to jodal/mopidy that referenced this issue Feb 10, 2016

audio: Workaround crash caused by race
Fixes mopidy#1430. See mopidy#1222 for explanation and proper fix.

jodal added a commit to jodal/mopidy that referenced this issue Feb 10, 2016

audio: Workaround crash caused by race
Fixes mopidy#1430. See mopidy#1222 for explanation and proper fix.

@jodal jodal self-assigned this Feb 10, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment