-
Notifications
You must be signed in to change notification settings - Fork 695
Remove deprecated Core APIs #1461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
A-core
Area: Core layer
breaking change
A breaking change that requires a major version bump
good first issue
Call for participation
Milestone
Comments
jodal
added a commit
to jodal/mopidy
that referenced
this issue
Jun 4, 2019
Greatly contributes towards mopidy#1083 and mopidy#1461.
jodal
added a commit
to jodal/mopidy
that referenced
this issue
Jun 4, 2019
Greatly contributes towards mopidy#1083 and mopidy#1461.
jodal
added a commit
to jodal/mopidy
that referenced
this issue
Jun 5, 2019
Contributes to mopidy#1461
jodal
added a commit
to jodal/mopidy
that referenced
this issue
Jun 5, 2019
Contributes to mopidy#1461
jodal
added a commit
to jodal/mopidy
that referenced
this issue
Jun 5, 2019
Contributes to mopidy#1461
This was referenced Jun 5, 2019
We should ignore the items about other extensions above. Extensions will have to cross this bridge themselves. What remains to close this issue is to:
|
I've deferred removing the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-core
Area: Core layer
breaking change
A breaking change that requires a major version bump
good first issue
Call for participation
Our Core API is starting to become quite cluttered with old deprecated APIs that we need to remove to make the API easier to use correctly. In additon, removing the old
@property
APIs will lead to some performance improvements, given the way Pykka proxies currently accesses the properties when inspecting the actor's interface.Before we can remove the deprecated core APIs, we need to stop using them. Luckily, none of the WebSocket API based clients have ever had access to the deprecated properties, reducing the scope of this a great deal.
Update Mopidy tests to not use deprecated APIs. See Update tests to stop using deprecated APIs #1083.Review all Python-based Mopidy Core API users. See https://github.com/jodal/mopidy-core-api-users for an easy way to search across the source code of many extensions.Extensions that needs to be updated:
...more extensions identified by the review mentioned above...Remove deprecated APIs:
Core
uri_schemes
propertyversion
propertyLibraryController
find_exact()
methodlookup()
method'suri
argumentsearch()
method's empty query returns everything behaviorsearch()
method'skwargs
argumentPlaybackController
current_tl_track
propertycurrent_track
propertystate
propertytime_position
propertyget_volume()
methodset_volume()
methodvolume
propertyget_mute()
methodset_mute()
methodmute
propertyPlaylistController
get_playlists()
methodplaylists
propertyfilter()
methodTracklistController
tl_tracks
propertytracks
propertylength
propertyversion
propertyconsume
propertyrandom
propertyrepeat
propertysingle
propertyadd()
method'stracks
argumentadd()
method'suri
argumentfilter()
method'skwargs
argumentremove()
method'skwargs
argumentThe text was updated successfully, but these errors were encountered: