New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Position freezes after seek in FLAC via HTTP #1462

Closed
dublok opened this Issue Feb 22, 2016 · 1 comment

Comments

2 participants
@dublok
Contributor

dublok commented Feb 22, 2016

Mopidy 2.0 9c05cc8. To reproduce:

  • play FLAC audio from UPnP server (or internet)
  • seek
  • -> position freezes

Problem: core.PlaybackController._on_position_changed is called with 0 instead of the expected position 171150, so seek never finishes.

https://github.com/mopidy/mopidy/blob/develop/mopidy/core/playback.py#L233

INFO     seek pending_pos=171150
INFO     Audio event: position_changed(position=0L)
INFO     _on_position_changed pos=0 pen_pos=171150
@adamcik

This comment has been minimized.

Member

adamcik commented Feb 22, 2016

https://botbot.me/freenode/mopidy/2016-02-08/?msg=59602124 and onward has a suggestion for a possibly better way of handling seek detection. Problem with the current approach is that we listen for pad events. Which means that we catch the seek on it's way into the last element, and we might have a race.

@adamcik adamcik added this to the v2.0.1 - Bug fixes milestone Feb 22, 2016

adamcik added a commit that referenced this issue Jun 13, 2016

Merge pull request #1496 from dublok/fix/1462-flac-seek-freeze
audio: Ignore position of _on_position_changed callback (fixes #1462)

adamcik added a commit that referenced this issue Jul 25, 2016

Merge pull request #1496 from dublok/fix/1462-flac-seek-freeze
audio: Ignore position of _on_position_changed callback (fixes #1462)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment