Remove deprecated Audio APIs #1465

Open
jodal opened this Issue Feb 22, 2016 · 2 comments

Comments

3 participants
@jodal
Member

jodal commented Feb 22, 2016

We should remove all deprecated audio APIs:

  • Audio.emit_end_of_stream() method

@jodal jodal added this to the v3.0 - Python 2+3 support milestone Feb 22, 2016

@sticken88

This comment has been minimized.

Show comment
Hide comment
@sticken88

sticken88 May 16, 2016

Should we just remove it or replace it with something else/similar?

Should we just remove it or replace it with something else/similar?

@kingosticks

This comment has been minimized.

Show comment
Hide comment
@kingosticks

kingosticks May 16, 2016

Member

This is really just a reminder to remove these. Anything marked as deprecated for removal in the next major version should already be handled in some other way (or no longer required at all) in the current version.

In the case of Audio.emit_end_of_stream() the changelog has the details:

Deprecated mopidy.audio.Audio.emit_end_of_stream(). Pass a None buffer to mopidy.audio.Audio.emit_data() to end the stream. This should only affect Mopidy-Spotify.

Member

kingosticks commented May 16, 2016

This is really just a reminder to remove these. Anything marked as deprecated for removal in the next major version should already be handled in some other way (or no longer required at all) in the current version.

In the case of Audio.emit_end_of_stream() the changelog has the details:

Deprecated mopidy.audio.Audio.emit_end_of_stream(). Pass a None buffer to mopidy.audio.Audio.emit_data() to end the stream. This should only affect Mopidy-Spotify.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment