Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated Audio APIs #1465

Closed
jodal opened this issue Feb 22, 2016 · 2 comments
Closed

Remove deprecated Audio APIs #1465

jodal opened this issue Feb 22, 2016 · 2 comments
Assignees
Milestone

Comments

@jodal
Copy link
Member

@jodal jodal commented Feb 22, 2016

We should remove all deprecated audio APIs:

  • Audio.emit_end_of_stream() method
@sticken88

This comment has been minimized.

Copy link

@sticken88 sticken88 commented May 16, 2016

Should we just remove it or replace it with something else/similar?

@kingosticks

This comment has been minimized.

Copy link
Member

@kingosticks kingosticks commented May 16, 2016

This is really just a reminder to remove these. Anything marked as deprecated for removal in the next major version should already be handled in some other way (or no longer required at all) in the current version.

In the case of Audio.emit_end_of_stream() the changelog has the details:

Deprecated mopidy.audio.Audio.emit_end_of_stream(). Pass a None buffer to mopidy.audio.Audio.emit_data() to end the stream. This should only affect Mopidy-Spotify.

@jodal jodal self-assigned this Sep 29, 2018
jodal added a commit to jodal/mopidy that referenced this issue Sep 29, 2018
jodal added a commit to jodal/mopidy that referenced this issue Sep 30, 2018
@jodal jodal closed this in #1705 Oct 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.