Skip to content

Remove deprecated Audio APIs #1465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task
jodal opened this issue Feb 22, 2016 · 2 comments
Closed
1 task

Remove deprecated Audio APIs #1465

jodal opened this issue Feb 22, 2016 · 2 comments
Assignees
Labels
A-audio Area: Audio layer breaking change A breaking change that requires a major version bump
Milestone

Comments

@jodal
Copy link
Member

jodal commented Feb 22, 2016

We should remove all deprecated audio APIs:

  • Audio.emit_end_of_stream() method
@jodal jodal added A-audio Area: Audio layer breaking change A breaking change that requires a major version bump labels Feb 22, 2016
@jodal jodal added this to the v3.0 - Python 2+3 support milestone Feb 22, 2016
@sticken88
Copy link

Should we just remove it or replace it with something else/similar?

@kingosticks
Copy link
Member

This is really just a reminder to remove these. Anything marked as deprecated for removal in the next major version should already be handled in some other way (or no longer required at all) in the current version.

In the case of Audio.emit_end_of_stream() the changelog has the details:

Deprecated mopidy.audio.Audio.emit_end_of_stream(). Pass a None buffer to mopidy.audio.Audio.emit_data() to end the stream. This should only affect Mopidy-Spotify.

@jodal jodal self-assigned this Sep 29, 2018
jodal added a commit to jodal/mopidy that referenced this issue Sep 29, 2018
jodal added a commit to jodal/mopidy that referenced this issue Sep 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-audio Area: Audio layer breaking change A breaking change that requires a major version bump
Projects
None yet
Development

No branches or pull requests

3 participants