Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scanner: Image extraction is not working with GST1.0 #1469

Closed
dublok opened this issue Feb 24, 2016 · 2 comments
Closed

Scanner: Image extraction is not working with GST1.0 #1469

dublok opened this issue Feb 24, 2016 · 2 comments
Labels
A-audio Area: Audio layer C-bug Category: This is a bug

Comments

@dublok
Copy link
Contributor

dublok commented Feb 24, 2016

mopidy-local-images does not extract the cover-art from music files anymore (since GST1.0).

This issue has two sides:

mopid
`convert_taglist'() ignores image tags.
https://github.com/mopidy/mopidy/blob/develop/mopidy/audio/tags.py#L52
I miss something like

            elif isinstance(value, Gst.Sample):
                # do the image things here
                result[tag].append(bytes(value.get_buffer())) # ???

mopidy-local-images
Does not support GST1.0.
https://github.com/mopidy/mopidy-local-images/blob/develop/mopidy_local_images/library.py#L171
GST1.0 Gst.Buffer has no data attribute

@tkem
Copy link
Member

tkem commented Feb 26, 2016

AFAICS, if image tags are added as bytes objects as proposed, mopidy-local-images would fall back on using the object "as is" when there's no data attribute.

@jodal jodal added this to the v2.0.1 - Bug fixes milestone Mar 1, 2016
@jodal jodal added C-bug Category: This is a bug A-audio Area: Audio layer labels Mar 1, 2016
@jodal jodal changed the title Image extraction is not working with GST1.0 Scanner: Image extraction is not working with GST1.0 Mar 1, 2016
jodal added a commit that referenced this issue Mar 26, 2016
@jodal
Copy link
Member

jodal commented Mar 26, 2016

Fixed by PR #1472.

@jodal jodal closed this as completed Mar 26, 2016
tmyersjstar pushed a commit to tmyersjstar/mopidy that referenced this issue Apr 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-audio Area: Audio layer C-bug Category: This is a bug
Projects
None yet
Development

No branches or pull requests

3 participants