Inconsistent playlist state with repeat and consume

[k00mi]

If both repeat and consume modes are enabled and the last remaining song in the playlist has been played (i.e. playlist is empty, no song is playing), mopidy still reports it is playing the last song.

mpc output will look something like this:

Daylight Dies - A Life Less Lived
[playing] #1/0   0:00/8:23 (0%)
volume: 66%   repeat: on    random: off   single: off   consume: on

Note the [playing] #1/0.

Connecting with ncmpcc once in this state leads to a failed assertion in ncmpcpp because it tries to highlight song 1 of 0. Connections that were already established before the end of the song are not affected.

Confirmed with mopidy versions 2.0.0 and 2.0.1

[adamcik]

Possibly an easier starter. Assumption is based on the idea that one could add a test for this based on one of the current ones and then relatively safely change the core behavior.

[sticken88]

I'm trying to reproduce this but I don't know how to enable repeat and consume modes. Can you please help me?

[k00mi]

@sticken88: When connected with ncmpcpp, press r for repeat and R for consume. Check the manual if you're using a different client.

[adamcik]

Also adding a unit test for this is a must for anyone fixing this.

[sticken88]

@adamcik can you please share hints on how to do that?

[alexjaw]

Have testet and could not reproduce the issue - ncmpcpp consumed the tracks and was also set in repeat mode. Was able to add new tracks without restarting the application. Is this issue for the latest builds? I have tested with mopidy 2.0.0.

edit:
Can reproduce the issue - will give it a try.

progress:
Have a fix. TracklistController.next_track() will return None when only one track left in tracklist, and both repeat and consume modes are active. Are looking into the tests of TracklistController.

[k00mi]

@alexjaw I updated the description to address your points.

[alexjaw]

Submitted a pull request.

[jodal]

Fixed by #1549.