New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent playlist state with repeat and consume #1512

Closed
k00mi opened this Issue May 17, 2016 · 9 comments

Comments

5 participants
@k00mi

k00mi commented May 17, 2016

If both repeat and consume modes are enabled and the last remaining song in the playlist has been played (i.e. playlist is empty, no song is playing), mopidy still reports it is playing the last song.

mpc output will look something like this:

Daylight Dies - A Life Less Lived
[playing] #1/0   0:00/8:23 (0%)
volume: 66%   repeat: on    random: off   single: off   consume: on

Note the [playing] #1/0.

Connecting with ncmpcc once in this state leads to a failed assertion in ncmpcpp because it tries to highlight song 1 of 0. Connections that were already established before the end of the song are not affected.

Confirmed with mopidy versions 2.0.0 and 2.0.1

@adamcik

This comment has been minimized.

Member

adamcik commented Jun 19, 2016

Possibly an easier starter. Assumption is based on the idea that one could add a test for this based on one of the current ones and then relatively safely change the core behavior.

@sticken88

This comment has been minimized.

sticken88 commented Jul 9, 2016

I'm trying to reproduce this but I don't know how to enable repeat and consume modes. Can you please help me?

@k00mi

This comment has been minimized.

k00mi commented Jul 17, 2016

@sticken88: When connected with ncmpcpp, press r for repeat and R for consume. Check the manual if you're using a different client.

@adamcik

This comment has been minimized.

Member

adamcik commented Jul 25, 2016

Also adding a unit test for this is a must for anyone fixing this.

@adamcik adamcik added this to the v2.0.1 - Bug fixes milestone Jul 26, 2016

@sticken88

This comment has been minimized.

sticken88 commented Jul 29, 2016

@adamcik can you please share hints on how to do that?

@alexjaw

This comment has been minimized.

Contributor

alexjaw commented Aug 2, 2016

Have testet and could not reproduce the issue - ncmpcpp consumed the tracks and was also set in repeat mode. Was able to add new tracks without restarting the application. Is this issue for the latest builds? I have tested with mopidy 2.0.0.

edit:
Can reproduce the issue - will give it a try.

progress:
Have a fix. TracklistController.next_track() will return None when only one track left in tracklist, and both repeat and consume modes are active. Are looking into the tests of TracklistController.

@jodal jodal modified the milestones: v2.0.2 - Bug fixes, v2.0.1 - Bug fixes Aug 7, 2016

@k00mi

This comment has been minimized.

k00mi commented Aug 13, 2016

@alexjaw I updated the description to address your points.

@alexjaw

This comment has been minimized.

Contributor

alexjaw commented Aug 23, 2016

Submitted a pull request.

@jodal jodal modified the milestones: v2.1 - The rest of v2.0, v2.1.1 - Bug fixes Oct 24, 2016

@jodal

This comment has been minimized.

Member

jodal commented Oct 24, 2016

Fixed by #1549.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment