Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Streaming actor blocking mopidy till 80minutes timeout #1521
I think there is a bug in the streaming actor during the unwrapping step if the first scan fails.
When the scan fails with an exception, the code continues and tries to download the streaming uri. When this uri is already the final stream uri it will for sure take a while to download the whole stream ;)
This is where the issue / bug comes in. The default timeout is 5000 and I think this should be ms. But the underlying request object uses seconds. So the code waits for more than 80 minutes to get the content and check if it is a playlist.
This is the debug output during the described failure (I added the "download URI" debug message to see the uri and timeout):
The bad part about this bug is, that for the next 80 minutes mopidy is busy downloading the content and is not reacting to any command. Even a service restart is failing cause the download is still ongoing and is blocking the shutdown.
This is the exception handler starting the issue:
I would suggest to reduce the timeout to seconds when calling the download
But I'm not familiar with the code to see where the timeout issue really starts.