New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncaptured LookupError in `playlistinfo` handler #162

Closed
jodal opened this Issue Aug 23, 2012 · 6 comments

Comments

2 participants
@jodal
Member

jodal commented Aug 23, 2012

ERROR    Unhandled exception in MpdSession (urn:uuid:7f68f1ec-8ecf-45ea-b17c-65e9308824e9):
Traceback (most recent call last):
  File "/usr/lib/pymodules/python2.6/pykka/actor.py", line 168, in _run
    response = self._handle_receive(message)
  File "/usr/lib/pymodules/python2.6/pykka/actor.py", line 248, in _handle_receive
    return self.on_receive(message)
  File "/usr/lib/pymodules/python2.6/mopidy/utils/network.py", line 339, in on_receive
    self.on_line_received(line)
  File "/usr/lib/pymodules/python2.6/mopidy/frontends/mpd/__init__.py", line 89, in on_line_received
    response = self.dispatcher.handle_request(line)
  File "/usr/lib/pymodules/python2.6/mopidy/frontends/mpd/dispatcher.py", line 51, in handle_request
    return self._call_next_filter(request, response, filter_chain)
  File "/usr/lib/pymodules/python2.6/mopidy/frontends/mpd/dispatcher.py", line 72, in _call_next_filter
    return next_filter(request, response, filter_chain)
  File "/usr/lib/pymodules/python2.6/mopidy/frontends/mpd/dispatcher.py", line 81, in _catch_mpd_ack_errors_filter
    return self._call_next_filter(request, response, filter_chain)
  File "/usr/lib/pymodules/python2.6/mopidy/frontends/mpd/dispatcher.py", line 72, in _call_next_filter
    return next_filter(request, response, filter_chain)
  File "/usr/lib/pymodules/python2.6/mopidy/frontends/mpd/dispatcher.py", line 92, in _authenticate_filter
    return self._call_next_filter(request, response, filter_chain)
  File "/usr/lib/pymodules/python2.6/mopidy/frontends/mpd/dispatcher.py", line 72, in _call_next_filter
    return next_filter(request, response, filter_chain)
  File "/usr/lib/pymodules/python2.6/mopidy/frontends/mpd/dispatcher.py", line 114, in _command_list_filter
    response = self._call_next_filter(request, response, filter_chain)
  File "/usr/lib/pymodules/python2.6/mopidy/frontends/mpd/dispatcher.py", line 72, in _call_next_filter
    return next_filter(request, response, filter_chain)
  File "/usr/lib/pymodules/python2.6/mopidy/frontends/mpd/dispatcher.py", line 142, in _idle_filter
    response = self._call_next_filter(request, response, filter_chain)
  File "/usr/lib/pymodules/python2.6/mopidy/frontends/mpd/dispatcher.py", line 72, in _call_next_filter
    return next_filter(request, response, filter_chain)
  File "/usr/lib/pymodules/python2.6/mopidy/frontends/mpd/dispatcher.py", line 156, in _add_ok_filter
    response = self._call_next_filter(request, response, filter_chain)
  File "/usr/lib/pymodules/python2.6/mopidy/frontends/mpd/dispatcher.py", line 72, in _call_next_filter
    return next_filter(request, response, filter_chain)
  File "/usr/lib/pymodules/python2.6/mopidy/frontends/mpd/dispatcher.py", line 169, in _call_handler_filter
    response = self._format_response(self._call_handler(request))
  File "/usr/lib/pymodules/python2.6/mopidy/frontends/mpd/dispatcher.py", line 177, in _call_handler
    return handler(self.context, **kwargs)
  File "/usr/lib/pymodules/python2.6/mopidy/frontends/mpd/protocol/current_playlist.py", line 247, in playlistinfo
    cp_track = context.backend.current_playlist.get(cpid=songpos).get()
  File "/usr/lib/pymodules/python2.6/pykka/future.py", line 112, in get
    exec('raise exc_info[0], exc_info[1], exc_info[2]')
  File "/usr/lib/pymodules/python2.6/pykka/actor.py", line 168, in _run
    response = self._handle_receive(message)
  File "/usr/lib/pymodules/python2.6/pykka/actor.py", line 239, in _handle_receive
    return callee(*message['args'], **message['kwargs'])
  File "/usr/lib/pymodules/python2.6/mopidy/backends/base/current_playlist.py", line 135, in get
    raise LookupError(u'"%s" match no tracks' % criteria_string)
LookupError: "cpid=1" match no tracks
INFO     New MPD connection from [192.168.1.10]:53835
ERROR    Unhandled exception in MpdSession (urn:uuid:b5af3be0-caf0-4e67-a664-a72271b9a98c):
Traceback (most recent call last):
  File "/usr/lib/pymodules/python2.6/pykka/actor.py", line 168, in _run
    response = self._handle_receive(message)
  File "/usr/lib/pymodules/python2.6/pykka/actor.py", line 248, in _handle_receive
    return self.on_receive(message)
  File "/usr/lib/pymodules/python2.6/mopidy/utils/network.py", line 339, in on_receive
    self.on_line_received(line)
  File "/usr/lib/pymodules/python2.6/mopidy/frontends/mpd/__init__.py", line 89, in on_line_received
    response = self.dispatcher.handle_request(line)
  File "/usr/lib/pymodules/python2.6/mopidy/frontends/mpd/dispatcher.py", line 51, in handle_request
    return self._call_next_filter(request, response, filter_chain)
  File "/usr/lib/pymodules/python2.6/mopidy/frontends/mpd/dispatcher.py", line 72, in _call_next_filter
    return next_filter(request, response, filter_chain)
  File "/usr/lib/pymodules/python2.6/mopidy/frontends/mpd/dispatcher.py", line 81, in _catch_mpd_ack_errors_filter
    return self._call_next_filter(request, response, filter_chain)
  File "/usr/lib/pymodules/python2.6/mopidy/frontends/mpd/dispatcher.py", line 72, in _call_next_filter
    return next_filter(request, response, filter_chain)
  File "/usr/lib/pymodules/python2.6/mopidy/frontends/mpd/dispatcher.py", line 92, in _authenticate_filter
    return self._call_next_filter(request, response, filter_chain)
  File "/usr/lib/pymodules/python2.6/mopidy/frontends/mpd/dispatcher.py", line 72, in _call_next_filter
    return next_filter(request, response, filter_chain)
  File "/usr/lib/pymodules/python2.6/mopidy/frontends/mpd/dispatcher.py", line 114, in _command_list_filter
    response = self._call_next_filter(request, response, filter_chain)
  File "/usr/lib/pymodules/python2.6/mopidy/frontends/mpd/dispatcher.py", line 72, in _call_next_filter
    return next_filter(request, response, filter_chain)
  File "/usr/lib/pymodules/python2.6/mopidy/frontends/mpd/dispatcher.py", line 142, in _idle_filter
    response = self._call_next_filter(request, response, filter_chain)
  File "/usr/lib/pymodules/python2.6/mopidy/frontends/mpd/dispatcher.py", line 72, in _call_next_filter
    return next_filter(request, response, filter_chain)
  File "/usr/lib/pymodules/python2.6/mopidy/frontends/mpd/dispatcher.py", line 156, in _add_ok_filter
    response = self._call_next_filter(request, response, filter_chain)
  File "/usr/lib/pymodules/python2.6/mopidy/frontends/mpd/dispatcher.py", line 72, in _call_next_filter
    return next_filter(request, response, filter_chain)
  File "/usr/lib/pymodules/python2.6/mopidy/frontends/mpd/dispatcher.py", line 169, in _call_handler_filter
    response = self._format_response(self._call_handler(request))
  File "/usr/lib/pymodules/python2.6/mopidy/frontends/mpd/dispatcher.py", line 177, in _call_handler
    return handler(self.context, **kwargs)
  File "/usr/lib/pymodules/python2.6/mopidy/frontends/mpd/protocol/current_playlist.py", line 247, in playlistinfo
    cp_track = context.backend.current_playlist.get(cpid=songpos).get()
  File "/usr/lib/pymodules/python2.6/pykka/future.py", line 112, in get
    exec('raise exc_info[0], exc_info[1], exc_info[2]')
  File "/usr/lib/pymodules/python2.6/pykka/actor.py", line 168, in _run
    response = self._handle_receive(message)
  File "/usr/lib/pymodules/python2.6/pykka/actor.py", line 239, in _handle_receive
    return callee(*message['args'], **message['kwargs'])
  File "/usr/lib/pymodules/python2.6/mopidy/backends/base/current_playlist.py", line 135, in get
    raise LookupError(u'"%s" match no tracks' % criteria_string)
LookupError: "cpid=1" match no tracks
INFO     New MPD connection from [192.168.1.10]:53836
@jodal

This comment has been minimized.

Member

jodal commented Aug 23, 2012

This bug was reported on IRC by @mrvanes.

@jodal jodal closed this in 2262bf9 Aug 23, 2012

@mrvanes

This comment has been minimized.

mrvanes commented Aug 24, 2012

I manually applied the fix to current_playlist.py and have the following error in mopidy output while using RompR:
'NoneType' object has no attribute 'Empty'

Never seen this error before, so I expect a relation to the fix.

@jodal

This comment has been minimized.

Member

jodal commented Aug 24, 2012

Do you have a full stack trace?

@mrvanes

This comment has been minimized.

mrvanes commented Aug 24, 2012

No, I'm sorry, that's all. It's the result of running clean mopidy 1>logfile 2>&1
So either there was no stack trace, or I missed it. Will keep an eye on the logfile. Will check if RompR behaves better as well!

@jodal

This comment has been minimized.

Member

jodal commented Aug 24, 2012

You can run Mopidy with --save-debug-log to save verbose log output to mopidy.log in the current working directory, if that helps you.

@mrvanes

This comment has been minimized.

mrvanes commented Aug 24, 2012

Apart from the error, the patch fixes the broken functionality of RompR as far as I have been able to test.

@ghost ghost assigned jodal Sep 3, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment