Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote PendingDeprecationWarning to DeprecationWarning #1773

Closed
jodal opened this issue Jun 9, 2019 · 2 comments
Closed

Promote PendingDeprecationWarning to DeprecationWarning #1773

jodal opened this issue Jun 9, 2019 · 2 comments
Assignees
Labels
Milestone

Comments

@jodal
Copy link
Member

@jodal jodal commented Jun 9, 2019

We have a small set of PendingDeprecationWarning in our source code now:

  • core.playback.play() with "tl_track" argument is pending deprecation, use "tlid" instead
  • core.tracklist.eot_track() is pending deprecation, use tracklist.get_eot_tlid()
  • core.tracklist.next_track() is pending deprecation, use tracklist.get_next_tlid()
  • core.tracklist.previous_track() is pending deprecation, use tracklist.get_previous_tlid()

Before the release of 3.0, we should consider upgrading all of these to DeprecationWarning, so that they can be removed in 4.0.

@hugovk

This comment has been minimized.

Copy link
Contributor

@hugovk hugovk commented Aug 18, 2019

Please see PR #1786.

@jodal jodal assigned jodal and unassigned jodal Sep 30, 2019
@jodal jodal added this to To do in Mopidy 3 on Python 3 via automation Dec 9, 2019
@jodal

This comment has been minimized.

Copy link
Member Author

@jodal jodal commented Dec 14, 2019

Fixed by #1854 .

@jodal jodal closed this Dec 14, 2019
Mopidy 3 on Python 3 automation moved this from To do to Done in master branch Dec 14, 2019
@jodal jodal moved this from Done in master branch to Released in pre-release in Mopidy 3 on Python 3 Dec 14, 2019
@jodal jodal moved this from Released in pre-release to Released in final release in Mopidy 3 on Python 3 Dec 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Mopidy 3 on Python 3
  
Released in final release
2 participants
You can’t perform that action at this time.