Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New connections show own IP, not client IP #1788

Closed
BrainStone opened this issue Aug 20, 2019 · 3 comments
Closed

New connections show own IP, not client IP #1788

BrainStone opened this issue Aug 20, 2019 · 3 comments
Assignees
Milestone

Comments

@BrainStone
Copy link

@BrainStone BrainStone commented Aug 20, 2019

When a new client connects, Mopidy logs the IP of itself rather than the new client.

Note that the IP of the server is 10.128.2.161 and client I connected from is 10.128.2.41

Lines from the log:

  • /var/log/mopidy/mopidy.log:
    2019-08-20 08:31:57,539 INFO [12529:MpdSession-23] mopidy.mpd.session: New MPD connection from [::ffff:10.128.2.161]:6600
    
  • journalctl:
    Aug 20 08:45:40 CM-RASPI-1 mopidy[12529]: INFO     New MPD connection from [::ffff:10.128.2.161]:6600
    
@kingosticks

This comment has been minimized.

Copy link
Member

@kingosticks kingosticks commented Aug 20, 2019

Good catch, looks like we (I?) broke this in #1629.

@kingosticks kingosticks added this to the v2.2.4 milestone Aug 20, 2019
@BrainStone

This comment has been minimized.

Copy link
Author

@BrainStone BrainStone commented Aug 20, 2019

kingosticks added a commit to kingosticks/mopidy that referenced this issue Aug 20, 2019
kingosticks added a commit to kingosticks/mopidy that referenced this issue Aug 24, 2019
This, along with some formatting, was broken in mopidy#1629.
kingosticks added a commit to kingosticks/mopidy that referenced this issue Aug 24, 2019
This, along with some formatting, was broken in mopidy#1629.
kingosticks added a commit to kingosticks/mopidy that referenced this issue Aug 25, 2019
This, along with some formatting, was broken in mopidy#1629.
kingosticks added a commit to kingosticks/mopidy that referenced this issue Aug 25, 2019
This, along with some formatting, was broken in mopidy#1629.
kingosticks added a commit that referenced this issue Aug 25, 2019
network: log client address not server address. (Fixes #1788)
@kingosticks

This comment has been minimized.

Copy link
Member

@kingosticks kingosticks commented Aug 25, 2019

This was fixed in #1792 and will be available in the next release (v2.2.4).

@jodal jodal added this to the v2.3.0 milestone Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.