Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.0.0: Test suite trips over if mopidy-local extension is not installed #1861

Closed
girst opened this issue Dec 22, 2019 · 1 comment · Fixed by #1862
Closed

3.0.0: Test suite trips over if mopidy-local extension is not installed #1861

girst opened this issue Dec 22, 2019 · 1 comment · Fixed by #1862
Assignees
Labels
Milestone

Comments

@girst
Copy link

@girst girst commented Dec 22, 2019

here's the culprit: https://github.com/mopidy/mopidy/blob/develop/mopidy/local.py

I'm building fedora/rpmfusion packages and stumbled over this (this means, i can't easily install this extension without the main mopidy package available). congrats on finally getting 3.0 out the door :)

======================================================================
ERROR: local (unittest.loader._FailedTest)
----------------------------------------------------------------------
ImportError: Failed to import test module: local
Traceback (most recent call last):
  File "/usr/lib64/python3.7/unittest/loader.py", line 154, in loadTestsFromName
    module = __import__(module_name)
  File "/builddir/build/BUILD/Mopidy-3.0.0/mopidy/local.py", line 7, in <module>
    from mopidy_local import *  # noqa
ModuleNotFoundError: No module named 'mopidy_local'


----------------------------------------------------------------------
Ran 668 tests in 4.717s

FAILED (errors=1)
Test failed: <unittest.runner.TextTestResult run=668 errors=1 failures=0>
error: Test failed: <unittest.runner.TextTestResult run=668 errors=1 failures=0>
@jodal jodal self-assigned this Dec 22, 2019
@jodal jodal added this to the v3.0.1 milestone Dec 22, 2019
@jodal

This comment has been minimized.

Copy link
Member

@jodal jodal commented Dec 22, 2019

I'll fix this right away and ship 3.0.1.

Thank you! It feels really great to finally have shipped :-)

jodal added a commit to jodal/mopidy that referenced this issue Dec 22, 2019
@jodal jodal closed this in #1862 Dec 22, 2019
@jodal jodal added the C-bug label Dec 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.