Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

listplaylist and listplaylistinfo do not accept arguments in the same way as MPD does #218

Closed
abarisain opened this issue Oct 29, 2012 · 2 comments
Assignees
Labels
C-bug Category: This is a bug
Milestone

Comments

@abarisain
Copy link
Contributor

Mopidy doesn't accept playlist names when not in quotes.
The documentation says somewhere (sorry, I can't find it) to put every string in quotes, but MPD tolerates them without.

http://cl.ly/image/3J173L2Z0h0M (Mopidy is on the left, mpd on the right)

I don't know if some clients do not wrap the string around quotes, but I think that it needs to be implemented :)

Also, MPD handles the playlist names in a broken way (I noticed this while debugging my application) :
If you have a playlist named "X Y", MPD doesn't accept 'listplaylistinfo X\ Y'. 'listplaylistinfo "X Y"' works, as this is the expected behaviour, but 'listplaylistinfo "X\ Y"' also works !

That is totally wrong, because strings obviously do not work that way.

I'll let you decide if you want to implement this bugged behaviour into Mopidy. Personally, I'd say not to, but it's your call !

@jodal
Copy link
Member

jodal commented Nov 1, 2012

From MPD 0.16.0:

listplaylists
playlist: test_a
Last-Modified: 2010-06-24T18:45:10Z
playlist: test_b
Last-Modified: 2010-06-24T18:40:07Z
playlist: foo bar
Last-Modified: 2012-11-01T21:17:49Z
OK
listplaylist foo bar
ACK [2@0] {listplaylist} wrong number of arguments for "listplaylist"
listplaylist foo\ bar
ACK [2@0] {listplaylist} wrong number of arguments for "listplaylist"
listplaylist foo+bar
ACK [50@0] {listplaylist} No such playlist
listplaylist "foo bar"
OK
listplaylist test_a
OK

MPD doesn't accept space escapes like the shell does nor urlencoded space. In other words, any client not using quotes will not be able to use playlists with spaces in their name.

Anyway, we can support dropping the quotes for spaceless names. I don't know if I want to support escapes of the space inside quoted strings... we'll revisit that issue if there are clients depending on it working.

@jodal jodal closed this as completed in 6011289 Nov 1, 2012
@ghost ghost assigned jodal Nov 1, 2012
@abarisain
Copy link
Contributor Author

we'll revisit that issue if there are clients depending on it working.

To be honest, I think that (like mpdroid needed) these broken clients should be fixed.

Thanks ! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug
Projects
None yet
Development

No branches or pull requests

2 participants