New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the 'starred' playlist to the playlist catalog #326

Closed
vansoest opened this Issue Jan 28, 2013 · 9 comments

Comments

4 participants
@vansoest

vansoest commented Jan 28, 2013

I missed the 'starred' playlist from original spotify client at the mopidy playlist catalog.

@steinerlein

This comment has been minimized.

steinerlein commented Mar 22, 2013

Yes, this is one of the reasons I love using Spotify and this is very important to me :) unfortunately, I am not capable of doing the work..

@kingosticks

This comment has been minimized.

Member

kingosticks commented Mar 25, 2013

I was taking a look at this and it doesn't seem too tricky but I've not contributed to a project before so I'm taking my time over it. Support for retrieving the logged in user's starred playlist was added to pyspotify some time ago (mopidy/pyspotify@b299e90) but the playlist has no name (similar to mopidy/pyspotify#81) so we'd need to give it one. It's a bit hacky, but maybe we could assume all playlists without a name are starred playlists and manually set the name to "Starred by playlist_owner"?

@kingosticks

This comment has been minimized.

Member

kingosticks commented Mar 25, 2013

In general it might be good to somehow include the the playlist owner within the mopidy playlist structure. It seems reasonable there could be playlists with the same name when there's multiple backends, particularly when using shared remote beets libraries.

@jodal

This comment has been minimized.

Member

jodal commented Mar 25, 2013

Yeah, we've briefly talked about making the Spotify backend name playlists like "{name} by {owner}" in #114 to make playlist name collisions less probable. This is especially important for the MPD frontend, as the MPD protocol identifies playlists by name, not by URI.

@jodal

This comment has been minimized.

Member

jodal commented Mar 25, 2013

Thus, if we include session.starred() as a playlist we should name the playlist "Starred by {current user}" or "Starred by me". When mopidy/pyspotify#81 is resolved, we'll show other user's starred playlists as "Starred by {owner}".

@kingosticks

This comment has been minimized.

Member

kingosticks commented Mar 25, 2013

Well, implementing the "{name} by {owner}" solution to #114 gets my vote. Could we reopen it?

@jodal

This comment has been minimized.

Member

jodal commented Mar 25, 2013

It has never been closed ;-)

@kingosticks

This comment has been minimized.

Member

kingosticks commented Mar 25, 2013

Oops yeh, my bad, it was #217 that was closed (as I said, I'm still new to this!). So if I make the changes in my personal fork (in a feature branch?) I can do a pull request? Would something this trivial need tests?

Just to be clear, I'm talking about just implementing #114 here (for now).

@jodal

This comment has been minimized.

Member

jodal commented Apr 1, 2013

Fixed with the merge of pull request #376.

@jodal jodal closed this Apr 1, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment