Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Add the 'starred' playlist to the playlist catalog #326

Closed
vansoest opened this Issue · 9 comments

4 participants

@vansoest

I missed the 'starred' playlist from original spotify client at the mopidy playlist catalog.

@steinerlein

Yes, this is one of the reasons I love using Spotify and this is very important to me :) unfortunately, I am not capable of doing the work..

@kingosticks
Collaborator

I was taking a look at this and it doesn't seem too tricky but I've not contributed to a project before so I'm taking my time over it. Support for retrieving the logged in user's starred playlist was added to pyspotify some time ago (mopidy/pyspotify@b299e90) but the playlist has no name (similar to mopidy/pyspotify#81) so we'd need to give it one. It's a bit hacky, but maybe we could assume all playlists without a name are starred playlists and manually set the name to "Starred by playlist_owner"?

@kingosticks
Collaborator

In general it might be good to somehow include the the playlist owner within the mopidy playlist structure. It seems reasonable there could be playlists with the same name when there's multiple backends, particularly when using shared remote beets libraries.

@jodal
Owner

Yeah, we've briefly talked about making the Spotify backend name playlists like "{name} by {owner}" in #114 to make playlist name collisions less probable. This is especially important for the MPD frontend, as the MPD protocol identifies playlists by name, not by URI.

@jodal
Owner

Thus, if we include session.starred() as a playlist we should name the playlist "Starred by {current user}" or "Starred by me". When mopidy/pyspotify#81 is resolved, we'll show other user's starred playlists as "Starred by {owner}".

@kingosticks
Collaborator

Well, implementing the "{name} by {owner}" solution to #114 gets my vote. Could we reopen it?

@jodal
Owner

It has never been closed ;-)

@kingosticks
Collaborator

Oops yeh, my bad, it was #217 that was closed (as I said, I'm still new to this!). So if I make the changes in my personal fork (in a feature branch?) I can do a pull request? Would something this trivial need tests?

Just to be clear, I'm talking about just implementing #114 here (for now).

@trefis trefis referenced this issue from a commit in trefis/mopidy
@trefis trefis Adds 'Starred' playlist to the playlist catalog
Related to issue #326
211b20c
@jodal
Owner

Fixed with the merge of pull request #376.

@jodal jodal closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.