New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy configuration broken in 0.14 #472

Closed
jodal opened this Issue Jun 19, 2013 · 2 comments

Comments

2 participants
@jodal
Member

jodal commented Jun 19, 2013

In 0.13, we supported the following setting:

SPOTIFY_PROXY_HOST = u'http://10.0.0.17:8080'

In 0.14, this was changed with the new config system. The equivalent today would be:

[proxy]
hostname = http://10.0.0.17:8080

But this doesn't work, as proxy/hostname is validated as a hostname:

ERROR    Config value proxy/hostname must be a resolveable hostname or valid IP

I suggest that we add more proxy config values, making the following a working proxy config:

[proxy]
type = http
hostname = 10.0.0.17
port = 8080

Other possible values for proxy/type include https, socks4, socks5. These values match the types accepted by libspotify. Does these types match what we can provide to GStreamer as well?

@adamcik

This comment has been minimized.

Member

adamcik commented Jun 19, 2013

See http://cgit.freedesktop.org/gstreamer/gst-plugins-good/tree/ext/soup/gstsouphttpsrc.c#n21 and http://gstreamer.freedesktop.org/data/doc/gstreamer/head/gst-plugins-good-plugins/html/gst-plugins-good-plugins-souphttpsrc.html#GstSoupHTTPSrc--proxy for what the souphttpsrc supports. http://gstreamer.freedesktop.org/data/doc/gstreamer/head/gst-plugins-good-plugins/html/gst-plugins-good-plugins-rtspsrc.html#GstRTSPSrc--proxy and http://cgit.freedesktop.org/gstreamer/gst-plugins-good/tree/gst/rtsp/gstrtspsrc.c#n673 for rtspsrc.

As for naming s/type/scheme/ IMO. Otherwise like I said on IRC we need to decide if we just want the individual pieces pre split and then combine them to scheme://user:pw@host:port form before setting them on the gstreamer elements that can accept a proxy property (there is a introspection API for properties, but not all elements implement it as far as I know).

@jodal

This comment has been minimized.

Member

jodal commented Aug 1, 2013

Fixed by merge of #481.

@jodal jodal closed this Aug 1, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment