New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command 'single' doesn't work #496

Closed
fatg3erman opened this Issue Aug 15, 2013 · 2 comments

Comments

4 participants
@fatg3erman
Contributor

fatg3erman commented Aug 15, 2013

Send the mpd command 'single 1', and the docs say that playback should stop after the current track, but it doesn't - it just carries on.

'status' reports that the state has been set to 1, but it seems to be ignored.

Mopidy 0.14.2 from the ubuntu PPA.

@kingosticks

This comment has been minimized.

Member

kingosticks commented Aug 16, 2013

I've not tried this myself but looking at the code you must be right. There are some differences between get_tl_track_at_eot and get_tl_track_at_next to handle the combination of single and repeat but just single isn't handled in get_tl_track_at_eot as you'd expect. It might be worth waiting for #494 to be merged before fixing this.

@txomon

This comment has been minimized.

Member

txomon commented Aug 19, 2013

This should go more for #491 (#494 includes #491).

adamcik added a commit to adamcik/mopidy that referenced this issue Oct 20, 2013

local: Fix handling of single in eot_track (fixes mopidy#496)
- Adds test cases for code paths that caused bug
- Short circuits EOT next track handling when in single mode.

@jodal jodal closed this in #542 Oct 20, 2013

@ghost ghost assigned adamcik Oct 20, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment