Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Switch to registry system for installing features from extensions #601
Motivating factor for this switch is that continuing to add more hooks for frontends, backends, gst-elements, library update providers, webclient dirs etc. looks like it will end up un-maintainable. We already have the library update provider hook which is essentially an extension specific hook, and will likely need to add another one for #440, web clients, and likely one for local playlists.
Additionally for cases such as having library and playlist providers for the local backend, solving things at an extension level feels a bit clunky. In particular the case that is bugging me is that say we want to have
Ideally I would also like to have
If we do go for some registry like system there would also be a very simple upgrade path assuming we have something like the following:
So essentially what I believe remains, if we decide to go this path is to figure out the exact implementation of the
On a final note, using setup tools entry points could also be possible, but having the single entry point is probably something we want to stick with.
I think this sounds very reasonable and see no major drawbacks with this approach.
I agree that we probably want to use setuptools entry points just to find the
We'll of course have some standard hooks that matches the Extension methods we have today. For extension specific hooks, I suggest we dictate that they must start with the extension name, e.g.