New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging broken when using logging/config_file #661

Closed
jodal opened this Issue Jan 23, 2014 · 1 comment

Comments

1 participant
@jodal
Member

jodal commented Jan 23, 2014

Because of my recent changes to the log setup in 0.18.0 to get more useful -v/-vv/-vvv output, the use of logging/config_file is broken.

E.g. the Debian package init script use logging/config_file to log to /var/log/mopidy/mopidy.log. A few lines are logged here, but as soon as the extension and config loading is done, and the main log setup runs, you'll stop seeing any output to the log file, which makes debugging use of the Debian package init script quite hard.

The problem is simply that I'm using logger.propagate = False so that I can control mopidy* loggers and the root logger separately, with different log levels. The solution I imagine is to reimplement this with a custom logging filter on the root logger's handlers instead. That should give us the same flexibility without breaking "alternative" logging handlers like the one the Debian package is using through logging/config_file.

@ghost ghost assigned jodal Jan 23, 2014

@jodal

This comment has been minimized.

Member

jodal commented Jan 23, 2014

BTW, this is clearly a candidate for an 0.18.1 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment