New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing extension config shouldn't crash mopidy #682

Closed
adamcik opened this Issue Jan 31, 2014 · 4 comments

Comments

2 participants
@adamcik
Member

adamcik commented Jan 31, 2014

This keeps tripping up new users and we should consider changing it to a warning along the lines of Extension FOO disabled due to missing config values, run 'mopidy config' for more details or disable this extension in your config to hide this message.

We could also have a --strict-config flag that preserves the current behavior if we think there is still a real use case for it.

@adamcik

This comment has been minimized.

Member

adamcik commented Jan 31, 2014

Other take on this is updating extensions to ship with enabled = false unless they are in the main mopidy package.

@jodal

This comment has been minimized.

Member

jodal commented Feb 14, 2014

@adamcik I know you've started working on this. Do you have anything ready to be merged?

@adamcik

This comment has been minimized.

Member

adamcik commented Feb 16, 2014

684bfcf fixes this.

@adamcik adamcik closed this Feb 16, 2014

@jodal

This comment has been minimized.

Member

jodal commented Feb 16, 2014

And 01bef27 in the release/0.18.2 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment