New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn if module is configured but not installed #694

Closed
schinken opened this Issue Feb 17, 2014 · 3 comments

Comments

4 participants
@schinken
Contributor

schinken commented Feb 17, 2014

Throw a warning if a module e.g. "spotify" is configured but not installed.

I migrated my mopidy config recently but forgot to install mopidy-spotify which resulted in no errors but in a not working mopidy spotify connection.

It would be nice if there would be an warning for "spotify module configured but not installed/found"

@jodal jodal added the enhancement label Feb 17, 2014

@txomon

This comment has been minimized.

Member

txomon commented Feb 25, 2014

The problem I can see on this is that usually the only thing that a module leaves if not present, is what the user put in his config file, so that if I put

[rbd2]
enabled = false

What should mopidy say in your opinion? Take into account that everything (almost) is contained into the plugin... Also think about having a plugin read more values than the config under it's tag...

It is true thought that it would be easier to diagnose some problems that by distration or newbiness can one have (already had some of them... :3 )

@adamcik

This comment has been minimized.

Member

adamcik commented Feb 25, 2014

Extensions have access to the entire config, but they should only be using their own values or ones from core. We do don't enforce this, but we do expect extension to be well behaved.

Likely all we will add is a simple Found unknown config section 'foo', remove it or set 'config/ignore_unknown_sections' to true to silence this message.

adamcik added a commit to adamcik/mopidy that referenced this issue Feb 25, 2015

@jodal jodal added this to the v0.20 - Audio cleanup 1 milestone Feb 25, 2015

jodal added a commit that referenced this issue Feb 25, 2015

Merge pull request #1002 from adamcik/fix/694
config: Debug log ignored sections (fixes: #694)
@jodal

This comment has been minimized.

Member

jodal commented Feb 25, 2015

Fixed by #1002

@adamcik Seems like your "fixes: #nnn" syntax isn't what GitHub expects, ref https://help.github.com/articles/closing-issues-via-commit-messages/.

@jodal jodal closed this Feb 25, 2015

@jodal jodal added the 3 - Done label Feb 25, 2015

ZenithDK added a commit to ZenithDK/mopidy that referenced this issue Feb 28, 2015

@jodal jodal removed the 3 - Done label Mar 11, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment