New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle wrong spotify password #77

Closed
adamcik opened this Issue Mar 29, 2011 · 2 comments

Comments

3 participants
@adamcik
Member

adamcik commented Mar 29, 2011

Connecting with wrong password only yields the following in the normal logs:

INFO     Connected to Spotify
INFO     Disconnected from Spotify

subsequent searches simply time out :/

Using -v slightly gives more information, but one must know what 401 means to be able to make sense of this:

INFO     2011-03-30 00:07:33,050 [18286:MainThread] mopidy.core
  Disabled: mopidy.frontends.lastfm.LastfmFrontend (No module named pylast)
DEBUG    2011-03-30 00:07:33,057 [18286:Dummy-7] mopidy.backends.spotify.session_manager
  System message: 22:07:33.056 I [ap:1388] Connecting to AP ap.spotify.com:4070
DEBUG    2011-03-30 00:07:33,174 [18286:Dummy-7] mopidy.backends.spotify.session_manager
  System message: 22:07:33.174 I [ap:938] Connected to AP: 193.182.8.10:4070
DEBUG    2011-03-30 00:07:33,521 [18286:Dummy-7] mopidy.backends.spotify.session_manager
  System message: 22:07:33.521 E [ap:3396] Connection error:  401
INFO     2011-03-30 00:07:33,522 [18286:SpotifySMThread] mopidy.backends.spotify.session_manager
  Connected to Spotify
DEBUG    2011-03-30 00:07:33,522 [18286:SpotifySMThread] mopidy.backends.spotify.session_manager
  Preferring normal bitrate from Spotify
INFO     2011-03-30 00:07:33,522 [18286:SpotifySMThread] mopidy.backends.spotify.session_manager
  Disconnected from Spotify

This and similar cases, wrong username should at least be handled with WARNING log statement giving some sensible information about why we couldn't connect.

@bok

This comment has been minimized.

Contributor

bok commented Mar 30, 2011

The 2 commits below address this issue:

bok/mopidy@e0b212a

bok/pyspotify@0ffd993

Testing with a bad password:

INFO     -- Starting Mopidy 0.4.0 --
INFO     Mopidy uses SPOTIFY(R) CORE
INFO     MPD server running at [::ffff:127.0.0.1]:6600
INFO     Last.fm scrobbler not started
ERROR    Login error: Bad username and/or password
INFO     Disconnected from Spotify
@jodal

This comment has been minimized.

Member

jodal commented Mar 30, 2011

Merged into the develop branch in 4a5c0a6. Thanks!

@ghost ghost assigned jodal Apr 10, 2011

@jodal jodal closed this Apr 11, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment