New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension.setup() should raise NotImplementedError #813

Closed
adamcik opened this Issue Aug 3, 2014 · 0 comments

Comments

2 participants
@adamcik
Member

adamcik commented Aug 3, 2014

Having just wasted at least an hour hunting down why spotify wasn't working because of this I'm strongly for this breaking loudly when you have an old pre setup extension for some reason. Yes this shouldn't happen often, if at all, but this was a pain in the ass to debug (mopidy deps "lies" in this case btw).

Problem turned out to be that the 1.2.0 wheel was actually a 1.0.3 codebase, so it installs just fine. But since it has get_backends instead of setup it never gets used...

@adamcik adamcik added bug labels Aug 3, 2014

@jodal jodal added this to the v0.19.3 milestone Aug 3, 2014

@jodal jodal closed this in 837fb00 Aug 3, 2014

@jodal jodal self-assigned this Aug 3, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment