New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requesting albums for an artist via MPD frontend results in artist reply #817

Closed
languitar opened this Issue Aug 5, 2014 · 1 comment

Comments

3 participants
@languitar

languitar commented Aug 5, 2014

I just upgraded mopidy to version 0.19.2 and since this upgrade the MPD frontend is partially broken in combination with MPDroid. When browsing an artist for contained albums the MPD frontend replies with artists again and I can never find the actual albums or tracks. Browsing the files directly via MPDroid is, however, completely possible.

This log section illustrates the wrong behavior:

DEBUG    2014-08-05 16:43:04,540 [1364:MpdSession-19] mopidy.mpd.session
  Request from [192.168.0.35]:56733: list "album" "Crystal Pasture"
DEBUG    2014-08-05 16:43:04,570 [1364:SpotifyBackend-5] mopidy_spotify.library
  Spotify search query: artist:"Crystal Pasture"
DEBUG    2014-08-05 16:43:04,775 [1364:SpotifyThread] pyspotify.manager.session
  Got message; processing events
DEBUG    2014-08-05 16:43:04,791 [1364:SpotifyThread] pyspotify.manager.session
  Will wait 12.978s for next message
DEBUG    2014-08-05 16:43:04,809 [1364:SpotifyThread] pyspotify.manager.session
  Got message; processing events
DEBUG    2014-08-05 16:43:04,821 [1364:SpotifyThread] pyspotify.manager.session
  Will wait 12.949s for next message
DEBUG    2014-08-05 16:43:05,741 [1364:MpdSession-19] mopidy.mpd.session
  Response to [192.168.0.35]:56733:
    Artist: Crystal Pasture
    OK
DEBUG    2014-08-05 16:43:05,839 [1364:MpdSession-19] mopidy.mpd.session
  Request from [192.168.0.35]:56733: command_list_ok_begin
DEBUG    2014-08-05 16:43:05,847 [1364:MpdSession-19] mopidy.mpd.session
  Request from [192.168.0.35]:56733: list "albumartist" "album" " Crystal Pasture"
DEBUG    2014-08-05 16:43:05,853 [1364:MpdSession-19] mopidy.mpd.session
  Request from [192.168.0.35]:56733: command_list_end
DEBUG    2014-08-05 16:43:05,884 [1364:SpotifyBackend-5] mopidy_spotify.library
  Spotify search query: album:" Crystal Pasture"
DEBUG    2014-08-05 16:43:06,226 [1364:SpotifyThread] pyspotify.manager.session
  Got message; processing events
DEBUG    2014-08-05 16:43:06,250 [1364:SpotifyThread] pyspotify.manager.session
  Will wait 11.519s for next message
DEBUG    2014-08-05 16:43:06,279 [1364:SpotifyThread] pyspotify.manager.session
  Got message; processing events
DEBUG    2014-08-05 16:43:06,304 [1364:SpotifyThread] pyspotify.manager.session
  Will wait 11.465s for next message
DEBUG    2014-08-05 16:43:09,121 [1364:MpdSession-19] mopidy.mpd.session
  Response to [192.168.0.35]:56733:
    list_OK
    OK

@languitar languitar changed the title from Requesting for an artist via MPD frontend results in artist reply to Requesting albums for an artist via MPD frontend results in artist reply Aug 5, 2014

@trygveaa trygveaa added MPD labels Aug 5, 2014

trygveaa added a commit that referenced this issue Aug 5, 2014

mpd: Test that "list album foo" responds correctly
Previously, test_list_album_with_artist_name would only test that the
command didn't fail. Now it also checks that the response is correct.
That is, that the response contains albums.

This makes the test detect the error reported in #817.

@trygveaa trygveaa closed this in ec41312 Aug 5, 2014

@jodal jodal added this to the v0.19.4 milestone Aug 5, 2014

@languitar

This comment has been minimized.

languitar commented Aug 5, 2014

Great, thanks!

trygveaa added a commit that referenced this issue Aug 5, 2014

mpd: Test that "list album foo" responds correctly
Previously, test_list_album_with_artist_name would only test that the
command didn't fail. Now it also checks that the response is correct.
That is, that the response contains albums.

This makes the test detect the error reported in #817.

(cherry picked from commit 9771eda)

trygveaa added a commit that referenced this issue Aug 5, 2014

mpd: Fix list commands with 3 arguments (fixes #817)
List commands with 3 arguments should return albums, not artists.

(cherry picked from commit ec41312)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment