New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong Root Directory when Browsing Local Library #833

Closed
tkem opened this Issue Aug 19, 2014 · 4 comments

Comments

3 participants
@tkem
Member

tkem commented Aug 19, 2014

According to http://docs.mopidy.com/en/develop/modules/local/#mopidy.local.Library.browse,

  Parameters:   path (string) – path to browse or None for root.

However, a local library gets passed b'local:directory when browsing the Local media root directory. So either code or documentation should be changed.

@adamcik adamcik added this to the v0.19.4 milestone Aug 24, 2014

@adamcik adamcik added Local labels Aug 24, 2014

@adamcik

This comment has been minimized.

Member

adamcik commented Aug 24, 2014

Seems like an oversight from before the API settled. Should indeed be fixed.

@adamcik

This comment has been minimized.

Member

adamcik commented Aug 24, 2014

Ideally to match what we ended up with in the corresponding core API.

@tkem

This comment has been minimized.

Member

tkem commented Aug 25, 2014

Would also be nice to define as a constant, e.g. local.Library.ROOT_URI; less magic strings in extensions.

@jodal jodal self-assigned this Aug 29, 2014

jodal added a commit that referenced this issue Aug 29, 2014

@jodal jodal closed this in 0e60730 Aug 29, 2014

@jodal

This comment has been minimized.

Member

jodal commented Aug 29, 2014

Should be fixed now. Please give the release/0.19.x or the develop branch a spin to test the changes, and if it looks good, I'll make a 0.19.4 release.

jodal added a commit that referenced this issue Aug 29, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment