New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add symlink support in scanning #858

Closed
adamcik opened this Issue Sep 21, 2014 · 11 comments

Comments

5 participants
@adamcik
Member

adamcik commented Sep 21, 2014

This is currently disabled on purpose, but we should consider adding support for enabling following links.

@adamcik adamcik added this to the v0.20 - Audio cleanup milestone Sep 21, 2014

@kingosticks

This comment has been minimized.

Member

kingosticks commented Sep 21, 2014

Out of interest, why is it disabled on purpose?

@adamcik

This comment has been minimized.

Member

adamcik commented Sep 21, 2014

  1. that is what the code currently does, 2) I think I might have done this under the guise of security, but I can't remember the details of my thinking, hence this bug.

https://twitter.com/zakmuK/status/511309079558754304 as the source for filling this.

@adamcik

This comment has been minimized.

Member

adamcik commented Oct 5, 2014

This also meant symlink loops has been a non issue.

@adamcik

This comment has been minimized.

Member

adamcik commented Dec 14, 2014

Currently there is only on/off and protection against loops. We currently make no effort to limit the device we end up on, or for that matter limiting our selves to just the music dir. But symlinks are now supported and we'll see if any more changes are needed based on feedback.

@adamcik adamcik closed this Dec 14, 2014

@morgoth

This comment has been minimized.

Contributor

morgoth commented Mar 10, 2015

I cannot make symlinks to work - is it supported now?

@jodal

This comment has been minimized.

Member

jodal commented Mar 10, 2015

The issue is closed, but the milestone is v0.20, which isn't released yet. The change is in the "develop" branch.

@morgoth

This comment has been minimized.

Contributor

morgoth commented Mar 10, 2015

Thanks for quick response.
To continue annoying questionnaire ;-) - when do you plan to release 0.20?

@jodal

This comment has been minimized.

Member

jodal commented Mar 10, 2015

"Real soon now" :-)

@ikogan

This comment has been minimized.

ikogan commented Feb 22, 2016

I'm currently running 2.0.0 and I can't seem to get the following setup to work:

pi@echo:/var/lib/mopidy/media $ ls -lah
total 8.0K
drwxr-xr-x  3 mopidy audio 4.0K Feb 15 18:49 .
drwxr-xr-x 10 mopidy audio 4.0K Feb  4 21:07 ..
drwxr-xr-x  3 root   root     0 Feb 16 20:20 Network
lrwxrwxrwx  1 root   root    17 Feb 15 18:49 USB -> /var/run/usbmount
pi@echo:/var/lib/mopidy/media $
pi@echo:/var/lib/mopidy/media $ ls -lah USB/
total 0
drwxr-xr-x  2 root root  60 Feb 16 20:20 .
drwxr-xr-x 20 root root 800 Feb 16 20:20 ..
lrwxrwxrwx  1 root root  11 Feb 16 20:20 SanDisk_Ultra_Fit_1 -> /media/usb0
pi@echo:/var/lib/mopidy/media $

I don't see the USB directory at all when I browse local files.

@kingosticks

This comment has been minimized.

Member

kingosticks commented Feb 22, 2016

Please, in future post usage question at http://discuss.mopidy.com rather than resurrect 12 month old closed issues here.

When you do so, please include the full output of mopidy deps and mopidy config. Please take particular note to include the value for the relevant config setting: https://docs.mopidy.com/en/latest/ext/local/#confval-local/scan_follow_symlinks

@ikogan

This comment has been minimized.

ikogan commented Feb 24, 2016

Apologies, I'll give that a shot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment