New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle exceptions from WebApp factory functions #875

Closed
tkem opened this Issue Oct 19, 2014 · 2 comments

Comments

3 participants
@tkem
Member

tkem commented Oct 19, 2014

Currently, if an exception is raised from any factory function registered under http:app, Mopidy's HTTP server will not start. IMO, such exceptions should be caught and logged for each WebApp individually, so that the other applications can run unaffected. See also mopidy/mopidy-local-sqlite#30.

@adamcik adamcik added this to the v0.19.5 - Bug fixes milestone Oct 19, 2014

@adamcik

This comment has been minimized.

Member

adamcik commented Dec 20, 2014

9a2f8a3 has a quick fix for this. Wasn't obvious how to add a test for this so leaving open in case @jodal has a suggestion for that bit.

@jodal

This comment has been minimized.

Member

jodal commented Dec 21, 2014

I can't immediately find a fitting test setup among our existing HTTP server tests that could be extended to test this too, so I'm leaving it as is.

I cherry-picked this fix to the release/v0.19.x branch for including in 0.19.5.

@jodal jodal closed this Dec 21, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment