New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seeking on paused track changes state to "playing" #939

Closed
tkem opened this Issue Jan 19, 2015 · 3 comments

Comments

4 participants
@tkem
Member

tkem commented Jan 19, 2015

I just discovered, much to my surprise, that calling mopidy.playback.seek with playback state "paused" apparently also changes the state to "playing". I was wondering if this is intentional behavior.

"websocket:outgoingMessage" Object { method: "core.playback.seek", params: Object, jsonrpc: "2.0", id: 53 } localhost:8100:28
"websocket:incomingMessage" message { target: WebSocket, isTrusted: true, data: "{"old_state": "paused", "new_state": "playing", "event": "playback_state_changed"}", origin: "ws://localhost:6680", lastEventId: "", eventPhase: 0, bubbles: false, cancelable: false, defaultPrevented: false, timeStamp: 1421641838638986, originalTarget: WebSocket } localhost:8100:28
"event:playbackStateChanged" Object { old_state: "paused", new_state: "playing" } localhost:8100:28
"websocket:incomingMessage" message { target: WebSocket, isTrusted: true, data: "{"jsonrpc": "2.0", "id": 53, "result": true}", origin: "ws://localhost:6680", lastEventId: "", eventPhase: 0, bubbles: false, cancelable: false, defaultPrevented: false, timeStamp: 1421641838650260, originalTarget: WebSocket }
"websocket:incomingMessage" message { target: WebSocket, isTrusted: true, data: "{"time_position": 720559, "tl_track": {"track": {"album": {"__model__": "Album", "name": "NPR: All Songs Considered Podcast", "num_tracks": 554, "uri": "podcast:https://www.npr.org/rss/podcast.php?id=510019", "artists": [{"__model__": "Artist", "name": "NPR"}], "images": ["http://media.npr.org/images/podcasts/thumbnail/icon_510019.jpg"]}, "__model__": "Track", "name": "Discoveries From globalFEST 2015", "uri": "podcast:https://www.npr.org/rss/podcast.php?id=510019#http://podcastdownload.npr.org/anon.npr-podcasts/podcast/510019/377005464/npr_377005464.mp3", "date": "2015-01-13", "length": 3273000, "track_no": 1, "artists": [{"__model__": "Artist", "name": "NPR"}], "genre": "Music"}, "__model__": "TlTrack", "tlid": 6}, "event": "track_playback_resumed"}", origin: "ws://localhost:6680", lastEventId: "", eventPhase: 0, bubbles: false, cancelable: false, defaultPrevented: false, timeStamp: 1421641838653188, originalTarget: WebSocket } localhost:8100:28
"event:trackPlaybackResumed" Object { time_position: 720559, tl_track: Object } localhost:8100:28
"websocket:incomingMessage" message { target: WebSocket, isTrusted: true, data: "{"time_position": 728579, "event": "seeked"}", origin: "ws://localhost:6680", lastEventId: "", eventPhase: 0, bubbles: false, cancelable: false, defaultPrevented: false, timeStamp: 1421641838661209, originalTarget: WebSocket } localhost:8100:28
"event:seeked" Object { time_position: 728579 }
@adamcik

This comment has been minimized.

Member

adamcik commented Mar 1, 2015

I thought we did this to mimic some existing behavior, but a quick test does indeed show that at least MPD doesn't auto resume on seek.

@ZenithDK

This comment has been minimized.

Contributor

ZenithDK commented Mar 1, 2015

I actually didn't check what the MPD behaviour is, and there was indeed a "local" testcase that made sure we changed from paused to playing after a seek. So it was intentional. Maybe they changed it also.

@tkem

This comment has been minimized.

Member

tkem commented Mar 1, 2015

I don't know about MPD, but I was surprised by Mopidy's behavior since this differs from any music player (soft- or hardware) I ever used (or can remember ;-)...

@adamcik adamcik closed this in #1018 Mar 1, 2015

@jodal jodal added this to the v0.20 - Audio cleanup 1 milestone Mar 1, 2015

@jodal jodal added the 3 - Done label Mar 1, 2015

@jodal jodal removed the 3 - Done label Mar 11, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment