New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding "sortname" Model properties #940

Closed
tkem opened this Issue Jan 19, 2015 · 6 comments

Comments

4 participants
@tkem
Member

tkem commented Jan 19, 2015

This would make it easier for clients to e.g. present a properly sorted list of artists from search results. Corresponding tags are already present in gstreamer, AFAICS.

@jodal jodal added the C-enhancement label Feb 26, 2015

@tkem

This comment has been minimized.

Member

tkem commented Mar 7, 2015

@adamcik

This comment has been minimized.

Member

adamcik commented Apr 5, 2015

+1 for adding this, should be a trivial thing to add to the models, and then a bit of followup in getting MPD to sort of it when appropriate and maybe including it in responses.

@jodal jodal added A-mpd A-core labels Apr 6, 2015

@adamcik adamcik added this to the v1.2 - Gapless milestone Apr 26, 2015

@adamcik adamcik modified the milestones: Europython 2015 sprint, v1.2 - Gapless Jun 24, 2015

@adamcik

This comment has been minimized.

Member

adamcik commented Jul 25, 2015

tagtypes
tagtype: Artist
tagtype: ArtistSort
tagtype: Album
tagtype: AlbumArtist
tagtype: AlbumArtistSort
tagtype: Title
tagtype: Track
tagtype: Name
tagtype: Genre
tagtype: Date
tagtype: Composer
tagtype: Performer
tagtype: Disc
tagtype: MUSICBRAINZ_ARTISTID
tagtype: MUSICBRAINZ_ALBUMID
tagtype: MUSICBRAINZ_ALBUMARTISTID
tagtype: MUSICBRAINZ_TRACKID
OK

for a quick overview of the types available in MPD as of 0.18 - i.e. we should make sure to expose these new fields in our MPD impl.

@east825

This comment has been minimized.

Contributor

east825 commented Jul 25, 2015

I'll try to implement it (as part of the sprint session on EuroPython 2015).

@adamcik

This comment has been minimized.

Member

adamcik commented Jul 25, 2015

Other step that would nice to have for this is updating the mopidy.audio.utils.convert_tags_to_track to populate the sortname data in the fields. The field name from GStreamer should be musicbrainz-sortname

east825 added a commit to east825/mopidy that referenced this issue Jul 25, 2015

adamcik added a commit that referenced this issue Jul 26, 2015

Merge pull request #1237 from east825/sprint-ep2015
models: Add "sortname" field in the Artist model (#940)
@jodal

This comment has been minimized.

Member

jodal commented Jul 26, 2015

Fixed by #1237.

@jodal jodal closed this Jul 26, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment