New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for stream titles in MPD protocol #944

Closed
adamcik opened this Issue Jan 21, 2015 · 5 comments

Comments

3 participants
@adamcik
Member

adamcik commented Jan 21, 2015

Turns out MPD metadata tags already support having a radio station title and a current track:

Title: Leggo Beast - Skanked
Name: Groove Salad: a nicely chilled plate of ambient beats and grooves. [SomaFM]

we need to add some way of supporting this in mopidy. This might require model changes on our side to better handle streams and possibly other things that cant be nicely shoehorned into our track models.

@adamcik

This comment has been minimized.

Member

adamcik commented Feb 25, 2015

One option could be to change the just added current_metadata_track to stream_metadata and only populate it with metadata from audio. Then when providing status in the MPD frontend we can consider the track metadata as the name and add the title from the stream if it is different from the name.

@adamcik

This comment has been minimized.

Member

adamcik commented Feb 25, 2015

Also we should probably do this before a 0.20 release.

@adamcik

This comment has been minimized.

Member

adamcik commented Feb 25, 2015

And relevant for #270

@jodal jodal added this to the v0.20 - Audio cleanup 1 milestone Feb 25, 2015

@AlexandrePTJ

This comment has been minimized.

Contributor

AlexandrePTJ commented Feb 27, 2015

Naming current_metadata_track to stream_metadata will be more precise indeed.
However I did not find the MPD's protocol key which can store Name. There is Track but I am not sure.

@adamcik

This comment has been minimized.

Member

adamcik commented Feb 27, 2015

I've never seen any mention of this in the protocol docs (I might have missed it of course), but if you fire up an MPD an play an icecast stream you will see the behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment