New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No event triggered when playlists are deleted #996

Closed
tkem opened this Issue Feb 24, 2015 · 1 comment

Comments

4 participants
@tkem
Member

tkem commented Feb 24, 2015

When calling PlaylistsController.create() or PlaylistsController.save(), a playst_changed event is sent, containing the respective playlist. No such event is sent when calling PlaylistsController.delete(), which may also be of interest to clients.

I don't think a playlist_changed event should be used here, since there is no longer any playlist to pass, and this may break existing clients. playlists_loaded is also not an option, since that means something completely different. So maybe a new playlist_deleted event might make sense, which just carries the URI of the deleted playlist.

Note that for an 1.0 API, it might also make sense to pass only the playlist URI with playlist_changed to avoid sending large models around.

tkem referenced this issue in tkem/mopidy Feb 24, 2015

tkem added a commit to tkem/mopidy that referenced this issue Feb 24, 2015

@dbrgn

This comment has been minimized.

Contributor

dbrgn commented Jul 25, 2015

I'll give this a stab :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment