New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve default get_images() implementation with album/artist URIs. #1013

Merged
merged 2 commits into from Feb 28, 2015

Conversation

2 participants
@tkem
Member

tkem commented Feb 27, 2015

This slightly improves the new default get_images() implementation when called with album or artist URIs. An album or artist URI lookup may result in multiple tracks which will probably share the same album(s), resulting in duplicate image URIs being reported. With this patch, image URIs belonging to all tracks reported for a given input URI are put into a set first, thus eliminating duplicates.

As a side effect, the default implementation now returns an empty list if no images can be found.

adamcik added a commit that referenced this pull request Feb 28, 2015

Merge pull request #1013 from tkem/fix/get_images
backend: Improve default get_images() implementation with album/artist URIs.

@adamcik adamcik merged commit 47911f2 into mopidy:develop Feb 28, 2015

2 checks passed

Scrutinizer 1 updated code elements
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@tkem tkem deleted the tkem:fix/get_images branch Mar 10, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment