New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework current metadata track to something ref based #1030

Merged
merged 8 commits into from Mar 13, 2015

Conversation

2 participants
@adamcik
Member

adamcik commented Mar 10, 2015

This still needs some work. The new core event can not be stream_changed, also I'm unsure about get_stream_reference with respect to #270 and just in general for how the track and stream metadata should coexist. I'm also tempted to add a new playback_track(tlid, ref) event which in combination with state changed events should replace the playing/paused/resumed/stopped events in time.

Should also fix #1012.

adamcik added some commits Mar 7, 2015

core: Switch to reference based stream info.
- Adds tests for new behaviors in core.
- Adds stream name to MPD format (fixes #944)
- Adds 'stream_changed' core event (needs a new name/event)
- Adds 'get_stream_reference' (which I'm also unsure about)

The bits I'm unsure about are mostly with respect to #270, but I'm going ahead
with this commit so we can discuss the details in PR with this code as an
example.

@jodal jodal added this to the v0.20 - Audio cleanup 1 milestone Mar 10, 2015

core: Reduce stream metadata to just the title
The API I really want for this to support regular tracks, stream updates and
dynamic playlists is still unclear to me. As such I'm taking the KISS approach
and reducing this to just the stream title and nothing else.

If all goes as planed this will be replaced by playback_track_changed(tlid, ref)
style events and other improvements in a later version.

@adamcik adamcik added the 2 - Working label Mar 13, 2015

:type key: boolean
:param mtime: if we should set mtime
:type mtime: boolean
:param stream_title: The current streams title.

This comment has been minimized.

@jodal

jodal Mar 13, 2015

Member

s/The/the/ and remove punctuation, to match style of other params.

jodal added a commit that referenced this pull request Mar 13, 2015

Merge pull request #1030 from adamcik/feature/stream-reference
Rework current metadata track to something ref based

@jodal jodal merged commit 51b83f0 into mopidy:develop Mar 13, 2015

2 checks passed

Scrutinizer 19 updated code elements
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jodal jodal added 3 - Done and removed 2 - Working labels Mar 13, 2015

@adamcik adamcik deleted the adamcik:feature/stream-reference branch Mar 13, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment