New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

models: Change Track.last_modified from seconds to ms #1036

Merged
merged 1 commit into from Mar 14, 2015

Conversation

2 participants
@jodal
Member

jodal commented Mar 13, 2015

No description provided.

@jodal jodal force-pushed the jodal:feature/track-last-modified-as-ms branch from c647cc3 to 3a61445 Mar 13, 2015

@jodal jodal added this to the v0.20 - Audio cleanup 1 milestone Mar 13, 2015

@jodal jodal added the 2 - Working label Mar 13, 2015

@adamcik

This comment has been minimized.

Member

adamcik commented Mar 13, 2015

We could add a check to the local scanner to see if the data looks 1000 times to large and workaround problems there?

@jodal

This comment has been minimized.

Member

jodal commented Mar 14, 2015

E.g. to just update the last_modified field to 1000x instead of rescanning the full library? Is that extra code/complexity really worth it? We'll have to do x1000 + 1, since a rescan will include the milliseconds, and thus the real files' mtime will be 0-999ms higher than the current last_modified x1000. Can we just go with rescan? Doesn't even need to rescan on upgrade, it's just that the next rescan will be full.

@adamcik

This comment has been minimized.

Member

adamcik commented Mar 14, 2015

Sure, good thing #1033 didn't make the scanning 4-5x slower in the end :-)

@jodal

This comment has been minimized.

Member

jodal commented Mar 14, 2015

Heh, then we hopefully wouldn't have merged #1033 ;-)

jodal added a commit that referenced this pull request Mar 14, 2015

Merge pull request #1036 from jodal/feature/track-last-modified-as-ms
models: Change Track.last_modified from seconds to ms (fixes #678)

@jodal jodal merged commit bb737e9 into mopidy:develop Mar 14, 2015

2 checks passed

Scrutinizer No new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jodal jodal deleted the jodal:feature/track-last-modified-as-ms branch Mar 14, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment