New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

local: Fix get_images() for local libraries returning single track from lookup(). #1037

Merged
merged 2 commits into from Mar 14, 2015

Conversation

2 participants
@tkem
Member

tkem commented Mar 14, 2015

Fix for PR #1032: Ignored the fact that local libraries could still return a single track from lookup() for backward-compatibility; results in

  File "/home/tkemmer/src/mopidy/mopidy/local/library.py", line 34, in get_images
    return self._library.get_images(uris)
  File "/home/tkemmer/src/mopidy/mopidy/local/__init__.py", line 119, in get_images
    for track in self.lookup(uri):
TypeError: 'Track' object is not iterable

tkem added some commits Mar 14, 2015

adamcik added a commit that referenced this pull request Mar 14, 2015

Merge pull request #1037 from tkem/fix/local_get_images_single_track
local: Fix get_images() for local libraries returning single track from lookup().

@adamcik adamcik merged commit 21b11b2 into mopidy:develop Mar 14, 2015

2 checks passed

Scrutinizer 2 updated code elements
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@adamcik adamcik added this to the v0.20 - Audio cleanup 1 milestone Mar 14, 2015

@adamcik adamcik self-assigned this Mar 14, 2015

@tkem tkem deleted the tkem:fix/local_get_images_single_track branch Mar 18, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment