New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decode all strerror-based exception messages #1044

Merged
merged 2 commits into from Mar 17, 2015

Conversation

2 participants
@jodal
Member

jodal commented Mar 17, 2015

I reviewed all instances of:

  • EnvironmentError
  • OSError
  • IOError
  • socket.error

In most cases, we already used encoding.locale_decode().

The case fixed in mopidy/utils/network.py fixes #971.

The case fixed in mopidy/utils/path.py might be triggered during a
local library scan.

Decode all strerror-based exception messages
I reviewed all instances of:

- EnvironmentError
- OSError
- IOError
- socket.error

In most cases, we already used encoding.locale_decode().

The case fixed in mopidy/utils/network.py fixes #971.

The case fixed in mopidy/utils/path.py might be triggered during a
local library scan.

@jodal jodal added this to the v0.20 - Audio cleanup 1 milestone Mar 17, 2015

@jodal jodal added 2 - Working and removed 2 - Working labels Mar 17, 2015

adamcik added a commit that referenced this pull request Mar 17, 2015

Merge pull request #1044 from jodal/fix/971-decode-strerror
Decode all strerror-based exception messages

@adamcik adamcik merged commit 6273247 into mopidy:develop Mar 17, 2015

2 checks passed

Scrutinizer No new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jodal jodal added 3 - Done and removed 1 - Ready labels Mar 17, 2015

@jodal jodal deleted the jodal:fix/971-decode-strerror branch Mar 17, 2015

@jodal jodal removed the 3 - Done label Mar 17, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment