New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: Make history.add() private #1063

Merged
merged 1 commit into from Mar 20, 2015

Conversation

2 participants
@jodal
Member

jodal commented Mar 20, 2015

Instead of changing the signature to add(uri, name) I opted for
renaming it to _add_track(track).

Since it's internal we may change it whenever we like to. Since you need
different logic for extracting an interesting name from a track and from
a ref or a stream title, it makes sense to add another method for adding
refs/stream titles to the history when that time comes.

Fixes #1056

@jodal jodal force-pushed the jodal:fix/1056-private-history-add branch from bb0a6a9 to 861f60e Mar 20, 2015

core: Make history.add() private
Instead of changing the signature to add(uri, name) I opted for
renaming it to _add_track(track).

Since it's internal we may change it whenever we like to. Since you need
different logic for extracting an interesting name from a track and from
a ref or a stream title, it makes sense to add another method for adding
refs/stream titles to the history when that time comes.

Fixes #1056

@jodal jodal added this to the v1.0 - Audio cleanup 1 milestone Mar 20, 2015

@jodal

This comment has been minimized.

Member

jodal commented Mar 20, 2015

Exiting how this could have caused a coverage reduction. /me goes hunting for coveralls settings.

@jodal

This comment has been minimized.

Member

jodal commented Mar 20, 2015

OK, I think I fixed the coveralls settings so they'll never make a PR fail. Care to ignore the red flag and merge? :-)

adamcik added a commit that referenced this pull request Mar 20, 2015

@adamcik adamcik merged commit a4c39f5 into mopidy:develop Mar 20, 2015

2 of 3 checks passed

coverage/coveralls Coverage decreased (-0.03%) to 76.36%
Details
Scrutinizer No new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jodal jodal deleted the jodal:fix/1056-private-history-add branch Mar 20, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment