New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove a bunch of API surface from core #1076

Merged
merged 6 commits into from Mar 23, 2015

Conversation

2 participants
@adamcik
Member

adamcik commented Mar 22, 2015

Note that the original goal was just #1070 - but I've done a bit more. As such I've left the changelog out for now as we might want to rebase this dropping some of these changes...

@adamcik adamcik added the A-core label Mar 22, 2015

@adamcik adamcik added this to the v1.0 - Audio cleanup 1 milestone Mar 22, 2015

"""
self._play(tl_track, 1)

This comment has been minimized.

@jodal

jodal Mar 22, 2015

Member

Would be more readable with self._play(tl_track, on_error_step=1).

@jodal

This comment has been minimized.

Member

jodal commented Mar 22, 2015

+1, changelog please :-)

@jodal jodal self-assigned this Mar 22, 2015

@adamcik

This comment has been minimized.

Member

adamcik commented Mar 23, 2015

This time I wasn't being lazy, I was postponing it as I wasn't sure if we wanted to merge all of these :-)

@jodal

This comment has been minimized.

Member

jodal commented Mar 23, 2015

I know, and I think they all look good.

@jodal jodal added the 2 - Working label Mar 23, 2015

@jodal

This comment has been minimized.

Member

jodal commented Mar 23, 2015

Ah, no hint about review comments being fixed!

@jodal jodal removed the 2 - Working label Mar 23, 2015

jodal added a commit that referenced this pull request Mar 23, 2015

Merge pull request #1076 from adamcik/fix/1070-shrink-core-api
Remove a bunch of API surface from core

@jodal jodal merged commit dad46df into mopidy:develop Mar 23, 2015

3 checks passed

Scrutinizer 5 updated code elements
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.0%) to 76.38%
Details

@jodal jodal referenced this pull request Mar 23, 2015

Closed

Hide change_track and error_step from core API #1070

1 of 1 task complete

@adamcik adamcik deleted the adamcik:fix/1070-shrink-core-api branch Mar 23, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment