New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

m3u: Replace slashes in playlist names with pipes. #1084

Merged
merged 2 commits into from Mar 25, 2015

Conversation

2 participants
@tkem
Member

tkem commented Mar 25, 2015

Reflecting what MPD does to playlist names; also stripping the name provided by the user, since leading/trailing spaces may easily creep in via the UI.

name = name.encode(encoding, errors='replace')
name = os.path.basename(name)
name = os.path.basename(name) # paranoia?

This comment has been minimized.

@jodal

jodal Mar 25, 2015

Member

Should be a noop when slashes are already replaced, but I feel safer leaving it in.

This comment has been minimized.

@tkem

tkem Mar 25, 2015

Member

That was my feeling, too (at least for now)

@jodal jodal added this to the v1.0 - Audio cleanup 1 milestone Mar 25, 2015

@jodal jodal self-assigned this Mar 25, 2015

jodal added a commit that referenced this pull request Mar 25, 2015

Merge pull request #1084 from tkem/feature/m3u_replace_invalid_chars
m3u: Replace slashes in playlist names with pipes.

@jodal jodal merged commit c9f6017 into mopidy:develop Mar 25, 2015

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Scrutinizer No new issues
Details
coverage/coveralls Coverage increased (+0.01%) to 76.54%
Details

@tkem tkem deleted the tkem:feature/m3u_replace_invalid_chars branch Mar 25, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment