New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delayed volume fixes #1101

Merged
merged 6 commits into from Apr 5, 2015

Conversation

2 participants
@adamcik
Member

adamcik commented Apr 3, 2015

Replaces PR #1099 and fixes #1097

adamcik added some commits Mar 31, 2015

audio: Make outputs helper only handle tee-ing.
The queue which is needed for gapless has been moved up to a
audio-sink bin which also wraps the outputs.
audio: Move software volume into audiosink.
This turns off playbin controlled volume, which implies that pulsesink volume
can no longer be controlled by Mopidy. This is likely something we have to
break, or at least rethink for multiple output support any way.

With this change we now have software volume after our large queue, which
means volume changes should happen much faster.
audio: Remove notify::mute/volume from software mixer
These will never be triggered externally when using plain software volume.
audio: Limit post tee queue size
Not sure how small we can safely make this, but basically with the volume
element in front of the tee we "need" this as small as possible so the volume
changes fell snappy. Alternative would be one volume element per tee branch.
audio: Adjust queue sizes.
These are mostly just gut feeling guesses. We should really start exposing at
least a few of these as settings soon.

@jodal jodal added this to the v1.0.x milestone Apr 5, 2015

@jodal jodal self-assigned this Apr 5, 2015

jodal added a commit that referenced this pull request Apr 5, 2015

@jodal jodal merged commit 0930cff into mopidy:v1.0.x Apr 5, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.12%) to 76.68%
Details

@jodal jodal referenced this pull request Apr 5, 2015

Closed

Delay on volume changes #1097

@adamcik adamcik deleted the adamcik:fix/1097-delayed-volume branch May 12, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment