Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delayed volume fixes #1101

Merged
merged 6 commits into from
Apr 5, 2015
Merged

Delayed volume fixes #1101

merged 6 commits into from
Apr 5, 2015

Conversation

adamcik
Copy link
Member

@adamcik adamcik commented Apr 3, 2015

Replaces PR #1099 and fixes #1097

The queue which is needed for gapless has been moved up to a
audio-sink bin which also wraps the outputs.
This turns off playbin controlled volume, which implies that pulsesink volume
can no longer be controlled by Mopidy. This is likely something we have to
break, or at least rethink for multiple output support any way.

With this change we now have software volume after our large queue, which
means volume changes should happen much faster.
These will never be triggered externally when using plain software volume.
Not sure how small we can safely make this, but basically with the volume
element in front of the tee we "need" this as small as possible so the volume
changes fell snappy. Alternative would be one volume element per tee branch.
These are mostly just gut feeling guesses. We should really start exposing at
least a few of these as settings soon.
@jodal jodal added this to the v1.0.x milestone Apr 5, 2015
@jodal jodal self-assigned this Apr 5, 2015
jodal added a commit that referenced this pull request Apr 5, 2015
@jodal jodal merged commit 0930cff into mopidy:v1.0.x Apr 5, 2015
@jodal jodal mentioned this pull request Apr 5, 2015
@adamcik adamcik deleted the fix/1097-delayed-volume branch May 12, 2015 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants