New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable testing of backends with global site-packages disabled #1115

Merged
merged 6 commits into from Apr 7, 2015

Conversation

2 participants
@jodal
Member

jodal commented Apr 7, 2015

This fixes #1068 for backends. I'll open a new issue for frontends, which we'll have to defer to 2.0.

@jodal jodal added this to the v1.1 - Gapless playback milestone Apr 7, 2015

@@ -0,0 +1,56 @@
from __future__ import absolute_import, unicode_literals

import ConfigParser

This comment has been minimized.

@adamcik

adamcik Apr 7, 2015

Member

import ConfigParser as configparser or whatever the p3k name is?

return dirs


def _get_user_dirs(xdg_config_dir):

This comment has been minimized.

@adamcik

adamcik Apr 7, 2015

Member

I would mention why we role our own instead of using glib/gobject.

@jodal jodal force-pushed the jodal:feature/no-global-sitepackages branch from 7fb72bb to ea52e8f Apr 7, 2015

@adamcik

This comment has been minimized.

Member

adamcik commented Apr 7, 2015

Done reviewing.

@jodal

This comment has been minimized.

Member

jodal commented Apr 7, 2015

Fixed.

adamcik added a commit that referenced this pull request Apr 7, 2015

Merge pull request #1115 from jodal/feature/no-global-sitepackages
Enable testing of backends with global site-packages disabled

@adamcik adamcik merged commit 0598a4e into mopidy:develop Apr 7, 2015

3 checks passed

Scrutinizer 11 updated code elements
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.03%) to 76.92%
Details

@jodal jodal deleted the jodal:feature/no-global-sitepackages branch Apr 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment