New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support / use TLID in core tracklist calls #1136

Merged
merged 7 commits into from Apr 21, 2015

Conversation

2 participants
@adamcik
Member

adamcik commented Apr 18, 2015

No description provided.

@adamcik adamcik added this to the v1.1 - Gapless playback milestone Apr 18, 2015

:param tl_track: the track to find the index of
:type tl_track: :class:`mopidy.models.TlTrack` or :class:`None`
:param tlid: of the track to find the index of
:type tlid: TLID number or :class:`None`

This comment has been minimized.

@jodal

jodal Apr 19, 2015

Member

s/of the/TLID of the/
s/TLID number/int/

@@ -301,7 +369,9 @@ def previous_track(self, tl_track):
if position in (None, 0):
return None
return self.get_tl_tracks()[position - 1]
# Note that since we know we are at position 1-n we know this will

This comment has been minimized.

@jodal

jodal Apr 19, 2015

Member

s/Note that since/Since/
s/1-n/n-1/ ?

"""
The TLID of the track that will be played after the given track.
Not necessarily the same track as :meth:`get_next_tlid`.

This comment has been minimized.

@jodal

jodal Apr 19, 2015

Member

s/track as/TLID as returned by/

Not necessarily the same track as :meth:`get_next_tlid`.
:rtype: TLID or :class:`None`

This comment has been minimized.

@jodal

jodal Apr 19, 2015

Member

s/TLID/int/

@jodal jodal self-assigned this Apr 19, 2015

@@ -45,13 +45,25 @@
'core.tracklist.remove:kwargs_criteria':
'tracklist.remove() with "kwargs" as criteria is deprecated',
'core.tracklist.eot_track':
'tracklist.eot_track() is deprecated, use tracklist.get_eot_tlid()',

This comment has been minimized.

@jodal

jodal Apr 19, 2015

Member

s/deprecated/pending deprecation/ ?

@jodal

This comment has been minimized.

Member

jodal commented Apr 19, 2015

+1 with comments

@adamcik

This comment has been minimized.

Member

adamcik commented Apr 19, 2015

Fixed

enabled this should be a random track, all tracks should be played once
before the tracklist repeats.
:rtype: TLID or :class:`None`

This comment has been minimized.

@jodal

jodal Apr 20, 2015

Member

s/TLID/int/

random and/or consume is enabled it should return the current track
instead.
:rtype: TLID or :class:`None`

This comment has been minimized.

@jodal

jodal Apr 20, 2015

Member

s/TLID/int/

@jodal

This comment has been minimized.

Member

jodal commented Apr 20, 2015

Since you didn't fix all occurrences of s/TLID/int/, I added comments on the two I can see left. :-)

@jodal jodal added the 2 - Working label Apr 20, 2015

@adamcik adamcik force-pushed the adamcik:feature/tlid-in-core-tracklist-calls branch from bee1ea3 to cb96238 Apr 20, 2015

@adamcik adamcik force-pushed the adamcik:feature/tlid-in-core-tracklist-calls branch from cb96238 to 9cec666 Apr 20, 2015

@adamcik

This comment has been minimized.

Member

adamcik commented Apr 20, 2015

There.

jodal added a commit that referenced this pull request Apr 21, 2015

Merge pull request #1136 from adamcik/feature/tlid-in-core-tracklist-…
…calls

Support / use TLID in core tracklist calls

@jodal jodal merged commit 0dfa3df into mopidy:develop Apr 21, 2015

3 checks passed

Scrutinizer 15 updated code elements
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.0%) to 77.08%
Details

@jodal jodal removed the 2 - Working label Apr 21, 2015

@adamcik adamcik deleted the adamcik:feature/tlid-in-core-tracklist-calls branch Apr 21, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment