Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mpd: Ignore tracks without length in the "count" command #1192

Merged
merged 1 commit into from
May 28, 2015
Merged

mpd: Ignore tracks without length in the "count" command #1192

merged 1 commit into from
May 28, 2015

Conversation

naglis
Copy link
Contributor

@naglis naglis commented May 27, 2015

Hello,
currently the MPD count command will raise a TypeError: unsupported operand type(s) for +: 'int' and 'NoneType' if one or more of the tracks has no length, in other words, the length is the default value None. This happens if a library provider does not provide track length information.

This is an attempt to fix this issue.

@adamcik
Copy link
Member

adamcik commented May 27, 2015

Looks like a good fix for that issue, and it has a test! Travis is failing as you didn't pass the flake8 check. Otherwise just add a quick entry in docs/changelog.rst mentioning this fix and we'll merge this :-)

@adamcik adamcik added this to the v1.1 - Robust core milestone May 27, 2015
@adamcik adamcik added MPD C-bug Category: This is a bug labels May 27, 2015
@adamcik
Copy link
Member

adamcik commented May 28, 2015

Thanks for the fix :-)

adamcik added a commit that referenced this pull request May 28, 2015
mpd: Ignore tracks without length in the "count" command
@adamcik adamcik merged commit 3527991 into mopidy:develop May 28, 2015
@adamcik adamcik self-assigned this May 28, 2015
@jodal
Copy link
Member

jodal commented May 28, 2015

+1

@naglis naglis deleted the fix/mpd-count-command branch May 29, 2015 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants