mpd:Update protocol version to 0.19 #1213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since mpd 0.19, it has concatenated multiple values using a ';' character. Mopidy has been using ', '. This makes mopidy use a ';' for all artist-related values. In mpd 0.18, multiple values were displayed as multiple lines in the output, hence this change bumps the mpd protocol version to 0.19 to reflect the new behaviour.
Update tests to reflect new function names
|
|
||
| def test_artists_to_mpd_format_artist_with_no_name(self): | ||
| def test_concatenate_muultiple_values_artist_with_no_name(self): |
|
This looks good, so I ended up just doing nitpicking :-) |
|
I'm pretty happy with that for a first attempt :) I'll address your comments as soon as I have a little more time. |
Address issues raised in review: Fix formatting by shortening function name to concat_multi_values Change comments and variable names to reflect generic nature of function Fix typos in tests Default to single quotes for strings
|
Protip: Watcher get no notifications when you push new commits to a PR, so a "I pushed some new commits" comment brings focus back to your PR a lot faster :-) |
jodal
added a commit
that referenced
this pull request
Jul 8, 2015
mpd: Concatenate multiple artist names, etc using ";" instead of multiple lines This is a part of updating the MPD protocol version to 0.19
|
Thanks for the tip :) Will this get merged to 1.0.x? |
|
No, I don't think so as it's really not a bug fix, but a protocol upgrade. What more is required for us to be 0.19 compatible? |
|
There is a new command: Other than that, I can't see any other (documented) changes. |
|
For the record: I've now added empty not implemented skeletons for all the new commands listed in the MPD 0.19.0 changelog. |
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since mpd 0.19, it has concatenated multiple values using
a ';' character. Mopidy has been using ', '. This makes mopidy
use a ';' for all artist-related values.
In mpd 0.18, multiple values were displayed as multiple lines in
the output, hence this change bumps the mpd protocol version to
0.19 to reflect the new behaviour.