New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mpd:Fix swapped Name and Title fields for streams #1214

Merged
merged 1 commit into from Jul 20, 2015

Conversation

3 participants
@fatg3erman
Contributor

fatg3erman commented Jul 8, 2015

Fixes #1212

When stream_title is set:
use stream_title for mpd's Title field, and use track.name (if set) for mpd's Name field

When stream_title is not set:
use track.name for mpd's Title field. Do not output Name field.

mpd:Fix swapped Name and Title fields for streams
Fixes issue#1212

When stream_title is set:
use stream_title for mpd's Title field, and use track.name (if set) for mpd's Name field

When stream_title is not set:
use track.name for mpd's Title field. Do not output Name field.

@jodal jodal added this to the v1.0.8 milestone Jul 20, 2015

@adamcik adamcik merged commit d0c255f into mopidy:develop Jul 20, 2015

3 checks passed

Scrutinizer No new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.02%) to 77.0%
Details
@adamcik

This comment has been minimized.

Member

adamcik commented Jul 20, 2015

Added some tests for this. Thanks :-)

@adamcik

This comment has been minimized.

Member

adamcik commented Jul 20, 2015

And cherrypicked into 1.0.x + changelog.

@fatg3erman fatg3erman deleted the fatg3erman:fix/1212-mpd-stream-name-title-reversed branch Jul 21, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment