New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue: #997 Add a track-list length limit. #1225

Merged
merged 4 commits into from Jul 20, 2015

Conversation

3 participants
@RonaldZ
Contributor

RonaldZ commented Jul 20, 2015

Added in the check to the add method in core/tracklist.py, added the schema to core/actor.py, and added the max_tracklist_length to the config file. Even if the config tracklist length has a ceiling of 10,000 and the default is 10,000. Also added in the core config values to relevant test cases. I think that's everything mentioned in 997.

Any suggestions/concerns?

self.core._config['core']['max_tracklist_length']):
raise exceptions.TracklistFull(
'TracklistFull: Tried to add ' +

This comment has been minimized.

@adamcik

adamcik Jul 20, 2015

Member

Minor nitpicks:

  • Having the exception name in the msg is probably overkill
  • The + for string concatenation isn't needed
  • s/uris/URIs/
  • Message sounds a bit like you added to many URIs at once, not that the queue is full

We'll update the message after merging it.

class CoreError(MopidyException):
def __init(self, message, errno=None):
super(CoreError, self).__init(message, errno)

This comment has been minimized.

@adamcik

adamcik Jul 20, 2015

Member

Should be __init__

@adamcik adamcik merged commit 82ed660 into mopidy:develop Jul 20, 2015

3 checks passed

Scrutinizer 4 updated code elements
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.04%) to 75.411%
Details
@adamcik

This comment has been minimized.

Member

adamcik commented Jul 20, 2015

Undid the core extension and fixed the nitpicks. Thanks :-)

@jodal jodal added this to the v1.1 - Robust core milestone Jul 20, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment