New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: Add config for data/config/cache directories #1232

Merged
merged 7 commits into from Jul 26, 2015

Conversation

3 participants
@dprokic

dprokic commented Jul 25, 2015

Issue #843

I will add more commits during the day. Next thing I will work on are the tests.

@jodal

This comment has been minimized.

Member

jodal commented Jul 25, 2015

Small nitpick: I'd reorder the core config values, so max_tracklist_length comes last.

@dprokic

This comment has been minimized.

dprokic commented Jul 25, 2015

OK.

Dejan Prokić added some commits Jul 25, 2015

Dejan Prokić
config: Reorder core config options
As suggested by jodal on pull request #1232
Issue #843
Dejan Prokić
tests: Add tests for defaults in core schema config
Tests check if default core schema has cache_dir, config_dir, data_dir and max_tracklist_length and if they have proper type

@jodal jodal modified the milestone: EuroPython 2015 sprint Jul 25, 2015

Dejan Prokić added some commits Jul 25, 2015

Dejan Prokić
tests: Make test_ext discoverable
Classes in this test didn't have prefix Test
@adamcik

This comment has been minimized.

Member

adamcik commented Jul 26, 2015

👍

@jodal jodal self-assigned this Jul 26, 2015

jodal added a commit that referenced this pull request Jul 26, 2015

Merge pull request #1232 from dprokic/feature/843-core-config-for-dat…
…a-config-cache-dirs

config: Add config for data/config/cache directories

@jodal jodal merged commit 0dc47e6 into mopidy:develop Jul 26, 2015

2 checks passed

Scrutinizer 7 updated code elements
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jodal

This comment has been minimized.

Member

jodal commented Jul 26, 2015

Thanks!

jodal added a commit that referenced this pull request Jul 26, 2015

@dprokic

This comment has been minimized.

dprokic commented Jul 26, 2015

Pleasure is mine :-)
26.07.2015. 12.26, "Stein Magnus Jodal" notifications@github.com је
написао/ла:

Thanks!


Reply to this email directly or view it on GitHub
#1232 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment