New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stream: Ignore file protocol if Mopidy-File is enabled #1254

Merged
merged 3 commits into from Aug 15, 2015

Conversation

2 participants
@jodal
Member

jodal commented Aug 15, 2015

If Mopidy-File is enabled it handles playback of file:// URIs.

Mopidy-Stream used to do this, but in Mopidy 1.1 we removed "file" from
the default value of the stream/protocols config. However, many users
upgrading to Mopidy 1.1 have set stream/protocols to include "file" in
their existing config, and thus Mopidy fails to start because both
backends tries to claim the "file" protocol.

Fixes #1248

stream: Ignore file protocol if Mopidy-File is enabled
If Mopidy-File is enabled it handles playback of file:// URIs.

Mopidy-Stream used to do this, but in Mopidy 1.1 we removed "file" from
the default value of the stream/protocols config. However, many users
upgrading to Mopidy 1.1 have set stream/protocols to include "file" in
their existing config, and thus Mopidy fails to start because both
backends tries to claim the "file" protocol.

Fixes #1248

@jodal jodal added this to the v1.1.1 - Bugfixes milestone Aug 15, 2015

@adamcik

This comment has been minimized.

Member

adamcik commented Aug 15, 2015

LGTM, b the merge needs to be resolved.

@adamcik adamcik self-assigned this Aug 15, 2015

@jodal

This comment has been minimized.

Member

jodal commented Aug 15, 2015

Fixed.

adamcik added a commit that referenced this pull request Aug 15, 2015

Merge pull request #1254 from jodal/feature/stream-without-file-protocol
stream: Ignore file protocol if Mopidy-File is enabled

@adamcik adamcik merged commit 43e6689 into mopidy:v1.1.x Aug 15, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.03%) to 77.856%
Details

@jodal jodal deleted the jodal:feature/stream-without-file-protocol branch Aug 17, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment