New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1250: Unwrap nested stream playlists #1281

Merged
merged 8 commits into from Sep 14, 2015

Conversation

2 participants
@jodal
Member

jodal commented Sep 13, 2015

No description provided.

@jodal jodal added this to the v1.1.1 - Bugfixes milestone Sep 13, 2015

@adamcik

This comment has been minimized.

adamcik commented on mopidy/stream/actor.py in 2d10eef Sep 13, 2015

This is probably OK for now, but seem to remember tunein having some case for needing to expand things and/or check which of the potential streams for a station is alive.

This comment has been minimized.

Owner

jodal replied Sep 14, 2015

I made the function private to avoid it being used externally as-is.

@adamcik

This comment has been minimized.

adamcik commented on mopidy/stream/actor.py in 2d10eef Sep 13, 2015

How are 404, 503, 401s etc handled by the downloader?

This comment has been minimized.

Owner

jodal replied Sep 14, 2015

It logs and returns None.

@adamcik

This comment has been minimized.

adamcik commented on mopidy/stream/actor.py in 2d10eef Sep 13, 2015

Add a TODO for tracking seen URIs to avoid loops? Or did we decide to just sidestep this by giving up after the timeout time anyway?

This comment has been minimized.

Owner

jodal replied Sep 14, 2015

The timeout should handle it, but if someone sets the timeout to 30s instead of 5s, it would be nice to not to burn system resources for 30s before failing. I'm adding a check.

@jodal

This comment has been minimized.

Member

jodal commented Sep 14, 2015

PR updated.

adamcik added a commit that referenced this pull request Sep 14, 2015

@adamcik adamcik merged commit c1c3847 into mopidy:release-1.1 Sep 14, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jodal jodal deleted the jodal:fix/1250-nested-stream-playlists branch Sep 14, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment