New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip tracks with empty uri in `track_to_mpd_format` #1343

Closed
wants to merge 1 commit into
base: develop
from

Conversation

3 participants
@blueyed
Contributor

blueyed commented Nov 29, 2015

Ref: #1340

@adamcik

This comment has been minimized.

Member

adamcik commented Nov 29, 2015

Perhaps it would make more sense to change https://github.com/mopidy/mopidy/blob/develop/mopidy/core/library.py#L238 which currently just checks that all entries are valid Tracks, to additionally filter out tracks without an URI.

This would save each frontend having to handle this bad data, and is still fairly backwards compatible for "bad" backends.

@adamcik

This comment has been minimized.

Member

adamcik commented Dec 5, 2015

Having this as an extra safety net on top of any core changes we do probably doesn't hurt. But currently this is failing a few tests.

@jodal jodal added this to the v1.1.2 - Bugfixes milestone Jan 1, 2016

jodal added a commit that referenced this pull request Jan 1, 2016

Merge PR #1343 from blueyed/track_to_mpd_format-skip-empty-uri into r…
…elease-1.1

Rebased from develop onto release-1.1, fixed tests, and added changelog.

Fixes #1343

@jodal jodal self-assigned this Jan 1, 2016

@jodal

This comment has been minimized.

Member

jodal commented Jan 1, 2016

I rebased this onto the release-1.1 branch and merged it to include it in the 1.1.2 bugfix release. I also fixed the broken tests and updated the changelog.

Thanks for the contribution!

@jodal jodal closed this Jan 1, 2016

@blueyed blueyed deleted the blueyed:track_to_mpd_format-skip-empty-uri branch Jan 2, 2016

@jodal jodal added the A-mpd label Jan 3, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment